Skip to content

Fix TaskerPluginRunner always using default NotificationProperties #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joaomgcd merged 1 commit into from
Sep 30, 2021
Merged

Fix TaskerPluginRunner always using default NotificationProperties #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...library/src/main/java/com/joaomgcd/taskerpluginlibrary/action/TaskerPluginRunnerAction.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ abstract class TaskerPluginRunnerAction<TInput : Any, TOutput : Any>() : TaskerP
internal fun runWithIntent(context: IntentServiceParallel?, taskerIntent: Intent?) :RunnerActionResult{
if (context == null) return RunnerActionResult(false)
if (taskerIntent == null) return RunnerActionResult(false)
context.startForegroundIfNeeded()
startForegroundIfNeeded(context)
try {
val input = taskerIntent.getTaskerInput(context, getInputClass(taskerIntent))
var result = run(context, input)
Expand Down
5 changes: 5 additions & 0 deletions ...pluginlibrary/src/main/java/com/joaomgcd/taskerpluginlibrary/runner/TaskerPluginRunner.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,11 @@ abstract class TaskerPluginRunner<TInput : Any, TOutput : Any> {
TaskerPluginRunner.startForegroundIfNeeded(this, notificationProperties)
}

@TargetApi(Build.VERSION_CODES.O)
fun startForegroundIfNeeded(intentServiceParallel: IntentServiceParallel) {
Copy link
Contributor Author

@jonahwh jonahwh Sep 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not use an extension function here as it would clash with IntentServiceParallel.startForegroundIfNeeded

TaskerPluginRunner.startForegroundIfNeeded(intentServiceParallel, notificationProperties)
}


companion object {
const val NOTIFICATION_CHANNEL_ID = "taskerpluginforegroundd"
Expand Down