set shouldPresentInFullscreen as true#33
Closed
lcanalimp wants to merge 1 commit intojoomcode:mainfrom
Closed
Conversation
set shouldPresentInFullscreen as true due iOS 17 known problem
39otrebla
approved these changes
Nov 7, 2023
mikhailmaslo
reviewed
Nov 9, 2023
|
|
||
| public override var shouldPresentInFullscreen: Bool { | ||
| false | ||
| true |
Collaborator
There was a problem hiding this comment.
Should we set it only for IOS 17?
I'm not sure how this flag affects older versions
Suggested change
| false | |
| true | |
| if #available(iOS 17.0, *) { | |
| return true | |
| } else { | |
| return false | |
| } |
Collaborator
Collaborator
|
Finished the same code here #38 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
set shouldPresentInFullscreen as true due iOS 17 known problem