Skip to content

set shouldPresentInFullscreen as true #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lcanalimp wants to merge 1 commit into from
Closed

set shouldPresentInFullscreen as true #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/BottomSheet/Core/Presentation/BottomSheetPresentationController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ public final class BottomSheetPresentationController: UIPresentationController {
}

public override var shouldPresentInFullscreen: Bool {
false
true
Copy link
Collaborator

@mikhailmaslo mikhailmaslo Nov 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we set it only for IOS 17?

I'm not sure how this flag affects older versions

Suggested change
false
true
if #available(iOS 17.0, *) {
return true
} else {
return false
}

}

public override var frameOfPresentedViewInContainerView: CGRect {
Expand Down