Fix configuredTime when configuration error#691
Merged
jraska merged 1 commit intojraska:masterfrom Mar 29, 2022
Merged
Conversation
Owner
|
Hey Jonny, great hearing from you!
I'm getting some discounts and lot of fun on top of it :D I hope you are doing great at Skyscanner ;) Let me just run CI on the PR and happy to merge this :) |
jraska
approved these changes
Mar 29, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
Contributor
|
This PR was released in 0.38.0. 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, hope you're getting lots of glovo discounts 😄
I found this issue at work today so may as well solve it here too. When an error occurs in a gradle build script
projectsEvaluated(gradle: Gradle)is never executed, meaning configuredTime = 0 and the configuration duration estimate will be 0-startTimeStamp.To fix this, when the value is null we can assume the configuration phase failed so we use the currentTime instead.
You can test this by adding
throw new Exception()into a project'sbuild.gradlefile and printingconfiguredTimeboth before and after this change by running./gradlew help