Skip to content

Fix configuredTime when configuration error #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jraska merged 1 commit into from
Mar 29, 2022
Merged

Fix configuredTime when configuration error #691

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions plugins/src/main/java/com/jraska/gradle/buildtime/BuildTimeListener.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ internal class BuildTimeListener(
private val buildReporter: BuildReporter
) : BuildListener {
private val taskExecutionStatisticsEventAdapter = TaskExecutionStatisticsEventAdapter()
private var configuredTime: Long = 0
private var configuredTime: Long? = null

override fun settingsEvaluated(gradle: Settings) = Unit
override fun projectsLoaded(gradle: Gradle) = Unit
Expand All @@ -26,7 +26,13 @@ internal class BuildTimeListener(
}

override fun buildFinished(result: BuildResult) {
val buildData = buildDataFactory.buildData(result, taskExecutionStatisticsEventAdapter.statistics, configuredTime)
if (configuredTime == null) {
val gradle = result.gradle as DefaultGradle
val services = gradle.services

configuredTime = services[Clock::class.java].currentTime
}
val buildData = buildDataFactory.buildData(result, taskExecutionStatisticsEventAdapter.statistics, configuredTime!!)

println("Build data collected in ${buildData.buildDataCollectionOverhead} ms")

Expand Down