feat: remove app timeout#1018
Merged
jujubot merged 5 commits intojuju:masterfrom Feb 1, 2024
yanksyoon:feat/remove_application_timeout
Merged
feat: remove app timeout#1018jujubot merged 5 commits intojuju:masterfrom yanksyoon:feat/remove_application_timeout
jujubot merged 5 commits intojuju:masterfrom
yanksyoon:feat/remove_application_timeout
Conversation
Contributor
1 similar comment
Contributor
Member
|
@cderici same again :) |
cderici
approved these changes
Jan 30, 2024
Contributor
cderici
left a comment
cderici
left a comment
There was a problem hiding this comment.
This LGTM. Thanks for the change ❤️The test might fail in the CI (because we're not doing the best job of handling exceptions in the asyncio event loop - and for some reason the GH actions exposes that), however, it passes for me locally. One little change in the test and we can land this safely.
Co-authored-by: Caner Derici <caner.derici@canonical.com>
Contributor
|
/build |
Contributor
|
/merge |
Contributor
|
/build |
Contributor
|
/merge |
Merged
jujubot
added a commit
that referenced
this pull request
Feb 13, 2024
#1024 ## What's Changed * Remove paramiko upper-bound by @gboutry in #1005 * Remove explicit passing of event_loop into tests by @cderici in #1006 * chore: remove the upper restrictions on the websockets dependency by @tonyandrewmeyer in #1007 * Target ceiling version by @cderici in #1008 * Make it easier to run tests using `make` by @cderici in #1012 * Avoid installing signal handlers to the event loop by @cderici in #1014 * feat: remove app block until done by @yanksyoon in #1017 * feat: remove app timeout by @yanksyoon in #1018 * Forward port latest changes from 2.9 onto 3.x by @cderici in #1022 #### Notes & Discussion JUJU-5414
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
<Please add why this change is needed and what it does.>
Adds timeout parameter to
model.remove_application()Addresses #855
<Fixes: >
QA Steps
<Commands / tests / steps to run to verify that the change works:>
All CI tests need to pass.
<Please note that most likely an additional test will be required by the reviewers for any change that's not a one liner to land.>
Notes & Discussion
<Additional notes for the reviewers if needed. Please delete section if not applicable.>