Forward port latest changes from 2.9 onto 3.x#1022
Merged
jujubot merged 6 commits intojuju:masterfrom Feb 8, 2024
Merged
Conversation
For both model and controller connections, accounts.yaml is required to have both username and password for connection to be established. This is not always true, for example, juju change-user-password actually removes the password from the accounts.yaml file.
Fixes juju#998 ControllerAPIInfoForModels call requires the uuid of the controller model, and if the user doesn't have at least read access, they won't be able to have that, and the update_endpoint call at the end of a regular connection fails.
jack-w-shaw
approved these changes
Feb 8, 2024
Member
jack-w-shaw
left a comment
jack-w-shaw
left a comment
There was a problem hiding this comment.
Provided the integration test failures are known failures, LGTM
Contributor
Author
yeah just tried them locally they pass 👍 thanks for the review! |
Contributor
Author
|
/merge |
Merged
jujubot
added a commit
that referenced
this pull request
Feb 13, 2024
#1024 ## What's Changed * Remove paramiko upper-bound by @gboutry in #1005 * Remove explicit passing of event_loop into tests by @cderici in #1006 * chore: remove the upper restrictions on the websockets dependency by @tonyandrewmeyer in #1007 * Target ceiling version by @cderici in #1008 * Make it easier to run tests using `make` by @cderici in #1012 * Avoid installing signal handlers to the event loop by @cderici in #1014 * feat: remove app block until done by @yanksyoon in #1017 * feat: remove app timeout by @yanksyoon in #1018 * Forward port latest changes from 2.9 onto 3.x by @cderici in #1022 #### Notes & Discussion JUJU-5414
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This brings onto the 3.x track some of the latest fixes from to the 2.9 track. Here're the details:
QA Steps
No QA needed for #990. For 1002 and 1003 please refer to their QA steps. Though they are very related so I'd expect the QA for both of them can be done in one fell swoop.
All CI tests need to pass (there's still some known intermittent ones in there).