fix zones constrains list parsing#1051
Closed
luissimas wants to merge 1 commit intojuju:masterfrom
luissimas:master
Closed
fix zones constrains list parsing#1051luissimas wants to merge 1 commit intojuju:masterfrom luissimas:master
luissimas wants to merge 1 commit intojuju:masterfrom
luissimas:master
Conversation
Contributor
1 similar comment
Contributor
Contributor
Author
|
Closing this one in favor of #1054 since it's merging from its own branch instead of master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #1050. This fixes the parsing of the
zonesconstraint in bundles. The format in the Juju API is defined in: https://github.com/juju/juju/blob/3.6/core/constraints/constraints.go#L107.QA Steps
The following python script can be used to verify both the bug in the current version as well as the fix implemented:
All CI tests need to pass.