fix zones constrains list parsing#1054
Merged
Conversation
Contributor
1 similar comment
Contributor
Aflynn50
approved these changes
May 30, 2024
Contributor
Aflynn50
left a comment
There was a problem hiding this comment.
This looks good, thanks for the fix!
Contributor
|
/merge |
Contributor
|
Hey @luissimas, we can't currently merge your contribution as the commit is not signed and our repo has a rule disallowing merges of unverified commits. Would you be able to follow this GitHub guide and force push a verified version of your commit? |
Contributor
Author
Done. I've also rebased on the main branch. |
Contributor
|
/merge |
Contributor
|
/build |
1 similar comment
Contributor
|
/build |
Contributor
|
/merge |
Contributor
|
/build |
Signed-off-by: Luís Simas <luis.nascimento@luizalabs.com>
Contributor
|
/build |
Contributor
|
/merge |
jujubot
added a commit
that referenced
this pull request
Jul 11, 2024
#1071 ## What's Changed * fix parsing of storage constraints by @luissimas in #1053 * Add setuptools to tox.ini by @Aflynn50 in #1058 * fix(refresh): bug with revisions by @jack-w-shaw in #1067 * feat: conventional commits static analysis by @SimonRichardson in #1068 * fix(series): add noble support by @jack-w-shaw in #1063 * fix zones constrains list parsing by @luissimas in #1054 * fix(model): fix wrong instanciation of list-secrets facade by @gboutry in #1065 * fix(makefile): run .tox before lint in makefile target by @cderici in #1069
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #1050. This fixes the parsing of the
zonesconstraint in bundles. The format in the Juju API is defined in: https://github.com/juju/juju/blob/3.6/core/constraints/constraints.go#L107.QA Steps
The following python script can be used to verify both the bug in the current version as well as the fix implemented:
All CI tests need to pass.