Conversation
cderici
left a comment
There was a problem hiding this comment.
Yeah this makes sense, let's also add an integration test that deploys a workload on noble, just to catch future regressions about that, because compatibility across versions will be relevant when the 4.0 comes, we don't wanna miss anything there.
9c3fdab to
95128b8
Compare
Integration test added |
|
/merge |
1 similar comment
|
/merge |
|
Hey guys! is there any ETA for this patch to land ? |
|
/merge |
|
Hm, it looks like merging is still blocked? |
|
@UtkarshBhatthere @sabaini Yeah we're currently working on fixing some trouble with the jenkins job, it should be fixed in a day or two, after that, we're good to go 👍 |
95128b8 to
cfd6897
Compare
|
/merge |
1 similar comment
|
/merge |
d46485c to
d920461
Compare
|
/merge |
The pylibjuju client hardcodes a mapping between series codename and the base channel. Noble was absent from this mapping, meaning pylibjuju doesn't know know to deploy to noble. Add noble to this mapping. After noble, we will only support deploying by base. Noble will be the last series added to this map Add an integration test which deploys a charm to noble
d920461 to
6bfbe24
Compare
|
/merge |
#1071 ## What's Changed * fix parsing of storage constraints by @luissimas in #1053 * Add setuptools to tox.ini by @Aflynn50 in #1058 * fix(refresh): bug with revisions by @jack-w-shaw in #1067 * feat: conventional commits static analysis by @SimonRichardson in #1068 * fix(series): add noble support by @jack-w-shaw in #1063 * fix zones constrains list parsing by @luissimas in #1054 * fix(model): fix wrong instanciation of list-secrets facade by @gboutry in #1065 * fix(makefile): run .tox before lint in makefile target by @cderici in #1069
The pylibjuju client hardcodes a mapping between series codename and the base channel.
Noble was absent from this mapping, meaning pylibjuju doesn't know know to deploy to noble.
Add noble to this mapping.
After noble, we will only support deploying by base. Noble will be the last series added to this map
Fixes: #1062
QA Steps
Download a local charm
juju download ubuntu, unzip, and amend themanifest,yamlto support ubuntu@24.04Place the charm dir at
./ubuntuYou will see
Then:
All CI tests need to pass.