fix(model): fix wrong instanciation of list-secrets facade#1065
Merged
fix(model): fix wrong instanciation of list-secrets facade#1065
Conversation
ListSecrets facade takes 2 arguments: `filter_`, and `show_secrets`. Previous instanciation passed a dict, which then landed in `filter_` field. Fix juju#947
Contributor
1 similar comment
Contributor
cderici
approved these changes
Jul 11, 2024
Contributor
|
/build |
Contributor
|
/merge |
jujubot
added a commit
that referenced
this pull request
Jul 11, 2024
#1071 ## What's Changed * fix parsing of storage constraints by @luissimas in #1053 * Add setuptools to tox.ini by @Aflynn50 in #1058 * fix(refresh): bug with revisions by @jack-w-shaw in #1067 * feat: conventional commits static analysis by @SimonRichardson in #1068 * fix(series): add noble support by @jack-w-shaw in #1063 * fix zones constrains list parsing by @luissimas in #1054 * fix(model): fix wrong instanciation of list-secrets facade by @gboutry in #1065 * fix(makefile): run .tox before lint in makefile target by @cderici in #1069
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ListSecrets facade takes 2 arguments:
filter_, andshow_secrets. Previous instanciation passed a dict, which then landed infilter_field.Fixes: #947
QA Steps
<Commands / tests / steps to run to verify that the change works:>
await f.ListSecrets(filter_={"uri": <secret_id>}, show_secrets=True)
All CI tests need to pass.
<Please note that most likely an additional test will be required by the reviewers for any change that's not a one liner to land.>
Notes & Discussion
<Additional notes for the reviewers if needed. Please delete section if not applicable.>