Skip to content

fix(model): fix wrong instanciation of list-secrets facade #1065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jujubot merged 4 commits into from
Jul 11, 2024
Merged

fix(model): fix wrong instanciation of list-secrets facade #1065

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4930a4f
fix(model): fix wrong instanciation of list-secrets facade
gboutry Jun 27, 2024
c921b55
Merge branch 'main' into fix/list-secrets
cderici Jul 11, 2024
ff813b5
Merge branch 'main' into fix/list-secrets
cderici Jul 11, 2024
aaf6de3
Merge branch 'main' into fix/list-secrets
cderici Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions juju/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2704,15 +2704,15 @@ async def update_secret(self, name, data_args=[], new_name="", file="", info="")
if result_error.error is not None:
raise JujuAPIError(result_error.error)

async def list_secrets(self, filter="", show_secrets=False):
async def list_secrets(self, filter=None, show_secrets=False):
"""
Returns the list of available secrets.
"""
facade = client.SecretsFacade.from_connection(self.connection())
results = await facade.ListSecrets({
'filter': filter,
'show-secrets': show_secrets,
})
results = await facade.ListSecrets(
filter_=filter,
show_secrets=show_secrets,
)
return results.results

async def remove_secret(self, secret_name, revision=-1):
Expand Down