Conversation
Contributor
Author
|
Well, this is weird, unit tests pass in CI and fail locally for me. Edit: separate PR to actually run unit tests in CI #1217 |
Contributor
Author
|
Fixes #1207 |
dimaqq
changed the title
dimaqq
force-pushed
the
websockets-fix-and-remove-upper-bound
branch
from
c0219ee to
5d2962e
Compare
james-garner-canonical
approved these changes
Nov 27, 2024
The websockets library has dropped the properties "open" and "closed" since websockets-13.0[0], this patch makes the changes needed to check for the connection's state as suggested by the documentation. [0] python-websockets/websockets@7c8e0b9
dimaqq
force-pushed
the
websockets-fix-and-remove-upper-bound
branch
from
5d2962e to
a53ce1e
Compare
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1215 plus removal of the websockets dep uppper bound