Merged
Conversation
blegat
commented
Feb 19, 2021
bf9e19e to
e69921f
Compare
Closed
7875c15 to
7563db9
Compare
27e2450 to
bb970bf
Compare
4 tasks
ddf9fe7 to
3c29f6b
Compare
This was referenced Mar 9, 2021
3c29f6b to
8afdfe2
Compare
Member
|
So this is actually slower than before, when run on the JuMP examples (The Before: 78.339035 seconds (204.57 M allocations: 11.833 GiB, 5.22% gc time, 6.89% compilation time)After: 88.580525 seconds (220.25 M allocations: 12.709 GiB, 5.61% gc time, 14.41% compilation time)However, it is more readable. I'd be in favor of merging so we can make other changes in future PRs. There are likely some performance things we can tweak. |
Member
Author
|
Thanks for doing a benchmark. I think there is an issue with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1234