Conversation
|
See the test failures. Is this breaking? |
984e5b3 to
ca557be
Compare
|
As briefly mentioned in #1245 (comment), This PR provides a non-breaking change that do not create the anonymous function by default and is non-breaking as if the user provides a custom function, the behavior is unchanged. |
odow
left a comment
There was a problem hiding this comment.
Nice. Does this improve the stress_precompile benchmark?
77a9ace to
83da6ae
Compare
|
With JuMP master, with the benchmark of jump-dev/JuMP.jl#2484 julia> @time Foo.example_diet()
18.208597 seconds (26.08 M allocations: 1.303 GiB, 4.28% gc time)After this PR: julia> @time Foo.example_diet()
17.757552 seconds (25.81 M allocations: 1.291 GiB, 4.34% gc time) |
Follows what the comment says.