Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

Revert vendor: Update libcontainer vendoring#503

Merged
lifupan merged 3 commits into
kata-containers:masterfrom
teawater:fix_shimv2
Mar 29, 2019
Merged

Revert vendor: Update libcontainer vendoring#503
lifupan merged 3 commits into
kata-containers:masterfrom
teawater:fix_shimv2

Conversation

@teawater
Copy link
Copy Markdown
Member

@teawater teawater commented Mar 28, 2019 •
edited
Loading

According discussion with @lifupan in kata-containers/runtime#1414
Try to revert vendor: Update libcontainer vendoring to fix the issue.

@jodh-intel
Copy link
Copy Markdown

jodh-intel commented Mar 28, 2019

/test

teawater added 3 commits March 28, 2019 19:49
@teawater
test: Revert "test: Fix mockContainer"
8f893b9 
This reverts commit ab489ae.
To fix shimv2 tests random fails.

Fixes: kata-containers#502

Signed-off-by: Hui Zhu <teawater@hyper.sh>
@teawater
agent: Revert "agent: Fix container creation"
7866668 
This reverts commit eb4eb55.
To fix shimv2 tests random fails.

Fixes: kata-containers#502

Signed-off-by: Hui Zhu <teawater@hyper.sh>
@teawater
vendor: Revert "vendor: Update libcontainer vendoring"
39696c0 
This reverts commit a3277aa.
To fix shimv2 tests random fails.

Fixes: kata-containers#502

Signed-off-by: Hui Zhu <teawater@hyper.sh>
@teawater
Copy link
Copy Markdown
Member Author

teawater commented Mar 28, 2019

I still cannot make sure that these patches can fix all the issue because the issue is around a random fail.
So I will do tests a lot of times to make sure the PR fix the issue on each test environment.

@teawater
Copy link
Copy Markdown
Member Author

teawater commented Mar 28, 2019

/test

@sboeuf
Copy link
Copy Markdown

sboeuf commented Mar 28, 2019

@teawater @jodh-intel I'd like to hear back from @lifupan on his analysis of why some kata-v2 tests are failing before we blindly revert this libcontainer revendoring.

@teawater
Copy link
Copy Markdown
Member Author

teawater commented Mar 29, 2019

1st test TestContainerListStatsWithIdFilter record:

  • Power8-ubuntu-16-04-PR-initrd
    Not test
  • opensuse-15-PR
    Not test
  • kata-metrics-agent-ubuntu-16-04
    Not test
  • kata-containers-agent-centos-7-4
    Not test
  • centos-7-4-PR-firecracker
    Not test
  • jenkins-ci-fedora
    pass
  • jenkins-ci-ubuntu-18-04
    pass
  • jenkins-ci-ubuntu-18-04-initrd
    pass
  • jenkins-ci-ubuntu-nemu
    pass

@teawater
Copy link
Copy Markdown
Member Author

teawater commented Mar 29, 2019

/retest

@lifupan
Copy link
Copy Markdown
Member

lifupan commented Mar 29, 2019

@teawater @jodh-intel I'd like to hear back from @lifupan on his analysis of why some kata-v2 tests are failing before we blindly revert this libcontainer revendoring.

Hi @sboeuf , I'm not pretty sure that the recent CI fails on shimv2 testcase is triggered by this libcontainer vendor upgrading, but I noticed those fails appeared from that PR #490. If we can make sure that those failures are related with it, I think we can just revert it temporarily until we find the root cause.

@teawater
Copy link
Copy Markdown
Member Author

teawater commented Mar 29, 2019

2nd test TestContainerListStatsWithIdFilter record:

  • Power8-ubuntu-16-04-PR-initrd
    Not test
  • opensuse-15-PR
    Not test
  • kata-metrics-agent-ubuntu-16-04
    Not test
  • kata-containers-agent-centos-7-4
    Not test
  • centos-7-4-PR-firecracker
    Not test
  • jenkins-ci-fedora
    pass
  • jenkins-ci-ubuntu-18-04
    pass
  • jenkins-ci-ubuntu-18-04-initrd
    pass
  • jenkins-ci-ubuntu-nemu
    pass

@teawater
Copy link
Copy Markdown
Member Author

teawater commented Mar 29, 2019

/retest

@teawater
Copy link
Copy Markdown
Member Author

teawater commented Mar 29, 2019

3rd test TestContainerListStatsWithIdFilter record:

  • Power8-ubuntu-16-04-PR-initrd
    Not test
  • opensuse-15-PR
    Not test
  • kata-metrics-agent-ubuntu-16-04
    Not test
  • kata-containers-agent-centos-7-4
    Not test
  • centos-7-4-PR-firecracker
    Not test
  • jenkins-ci-fedora
    pass
  • jenkins-ci-ubuntu-18-04
    pass
  • jenkins-ci-ubuntu-18-04-initrd
    pass
  • jenkins-ci-ubuntu-nemu
    pass

@teawater
Copy link
Copy Markdown
Member Author

teawater commented Mar 29, 2019

According to the test record, I think this PR handles the issue.

@sboeuf
Copy link
Copy Markdown

sboeuf commented Mar 29, 2019

@teawater @lifupan
We know this libcontainer vendoring is the problem, but reverting it is not really solving the problem...
For the sake of having the CI passing again, let's merge it, but @lifupan please try to find out what is going wrong with this, as we need this revendoring to solve other issues related to exec cgroups and CVE.

@lifupan
Copy link
Copy Markdown
Member

lifupan commented Mar 29, 2019

@teawater @lifupan
We know this libcontainer vendoring is the problem, but reverting it is not really solving the problem...
For the sake of having the CI passing again, let's merge it, but @lifupan please try to find out what is going wrong with this, as we need this revendoring to solve other issues related to exec cgroups and CVE.

@sboeuf
I'll have a look on this issue.

@lifupan lifupan merged commit 6b7d41a into kata-containers:master Mar 29, 2019
@sboeuf
Copy link
Copy Markdown

sboeuf commented Mar 29, 2019

Thanks @lifupan

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@jodh-intel jodh-intel jodh-intel approved these changes

@sboeuf sboeuf sboeuf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@teawater @jodh-intel @sboeuf @lifupan