Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

Fix yq issues#1414

Merged
grahamwhaley merged 2 commits into
kata-containers:masterfrom
teawater:yq_version
Apr 8, 2019
Merged

Fix yq issues#1414
grahamwhaley merged 2 commits into
kata-containers:masterfrom
teawater:yq_version

Conversation

@teawater
Copy link
Copy Markdown
Member

@teawater teawater commented Mar 25, 2019

  1. Set version to 2.3.0
  2. Check the fail of curl

@teawater
Copy link
Copy Markdown
Member Author

teawater commented Mar 25, 2019

/test

@teawater
Copy link
Copy Markdown
Member Author

teawater commented Mar 27, 2019

/test

@teawater teawater mentioned this pull request Mar 28, 2019
Closed
@lifupan
Copy link
Copy Markdown
Member

lifupan commented Mar 28, 2019

The CI failed on fedora is the same with the failed on kata-containers/agent#490, I'm not sure is this failed related with that PR, I'll have a look on this failed later.

This was referenced Mar 28, 2019
Closed
Merged
@teawater teawater mentioned this pull request Mar 28, 2019
Merged
teawater added 2 commits April 2, 2019 20:03
@teawater
ci: set $yq_version to 2.3.0
7fa0390 
According what I said in kata-containers/tests#1349,
use the last verion is not a good choice.
This commit set it to 2.3.0.

Fixes: kata-containers#1411

Signed-off-by: Hui Zhu <teawater@hyper.sh>
@teawater
ci: Add a failed execution check for curl
4993dff 
There is no checks for curl get 404 or something else.
Add a check for it.

Fixes: kata-containers#1411

Signed-off-by: Hui Zhu <teawater@hyper.sh>
@teawater
Copy link
Copy Markdown
Member Author

teawater commented Apr 2, 2019

/test

egernst
egernst reviewed Apr 3, 2019
View reviewed changes
Comment thread .ci/install-yq.sh
# The redirected url should include the latest release version
# https://github.com/mikefarah/yq/releases/tag/<VERSION-HERE>
yq_version=$(basename "${yq_latest_url}")
local yq_version=2.3.0
Copy link
Copy Markdown
Member

@egernst egernst Apr 3, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grahamwhaley - can you put your @jodh-intel hat on and PTAL? I know we have versions.yaml around, and wondering if we should be utilizing that instead of hardcoding in the installation script itself?

I don't want to necessarily hold up a fix, but...

Copy link
Copy Markdown
Contributor

@grahamwhaley grahamwhaley Apr 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is OK, to pin, to get stability. What I don't quite follow is that the curl of github release latest should be picking up the latest released version (which is 2.3.0 for yq right now), and not any HEAD version.
Thus, I actually think:

  • this change is currently benign
  • but in the long term, pinning to a known version probably gets us more stability than not pinning - but at the cost that we have to track.
    Hmm, actually then, @chavafg - do we think this yq version number should be wired into the versions.yaml files, and not hard wired here in a script??

Copy link
Copy Markdown
Member Author

@teawater teawater Apr 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@egernst @grahamwhaley I agree with put the request version to versions.yaml.
But yq is used to parse versions.yaml.

Copy link
Copy Markdown
Contributor

@grahamwhaley grahamwhaley Apr 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@teawater - heh, hah!
In which case, I have no issue with this - as long as we remember it is hard wired ;-)

grahamwhaley
grahamwhaley approved these changes Apr 8, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@grahamwhaley grahamwhaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.
let's see how it flies.

@grahamwhaley grahamwhaley merged commit 26ca2a3 into kata-containers:master Apr 8, 2019
@advancedwebdeveloper
Copy link
Copy Markdown

advancedwebdeveloper commented Sep 18, 2020

I got an issue on Ubuntu 20 x86_64 - I am using gollvm :

/kata-containers/src/runtime$ make GOPATH=/go
/bin/sh: 1: test: Illegal number: 15rc2
golang.mk:60: *** "ERROR: golang minor version too old: got 1.15rc2, need atleast 1.11". Stop.

In my case

$ yq -V
yq version 3.4.0

~/kata-containers/src/runtime$ go env && go version
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/oceanfish81/.cache/go-build"
GOENV="/home/oceanfish81/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/oceanfish81/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/oceanfish81/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/tools"
GCCGO="/usr/local/bin/llvm-goc"
AR="ar"
CC="/usr/bin/clang"
CXX="/usr/bin/clang++"
CGO_ENABLED="1"
GOMOD="/home/oceanfish81/kata-containers/src/runtime/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build179553929=/tmp/go-build -gno-record-gcc-switches -funwind-tables"
go version go1.15rc2 gollvm LLVM 12.0.0git linux/amd64

Ivan

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@egernst egernst egernst left review comments

@grahamwhaley grahamwhaley grahamwhaley approved these changes

@devimc devimc devimc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@teawater @lifupan @advancedwebdeveloper @grahamwhaley @devimc @egernst