Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.
This repository was archived by the owner on May 12, 2021. It is now read-only.

linter: remove deadcode linter check for generic item #1432

@Pennyzct

Description

@Pennyzct

ARM CI is failing, since we switch to the new golangci-lint.
Copy log from #1414:

18:09:54 func genericMemoryTopology(memoryMb, hostMemoryMb uint64, slots uint8, memoryOffset uint32) govmmQemu.Memory {
18:09:54      ^
18:09:54 cli/kata-check.go:55:2: `genericCPUFlagsTag` is unused (deadcode)
18:09:54 	genericCPUFlagsTag    = "flags"      // nolint: varcheck, unused
18:09:54 	^
18:09:54 cli/kata-check.go:56:2: `genericCPUVendorField` is unused (deadcode)
18:09:54 	genericCPUVendorField = "vendor_id"  // nolint: varcheck, unused
18:09:54 	^
18:09:54 cli/kata-check.go:57:2: `genericCPUModelField` is unused (deadcode)
18:09:54 	genericCPUModelField  = "model name" // nolint: varcheck, unused
18:09:54 	^
18:09:54 cli/kata-check_test.go:31:6: `testCPUData` is unused (deadcode)
18:09:54 type testCPUData struct {
18:09:54      ^
18:09:54 cli/kata-check_test.go:151:6: `genericTestGetCPUDetails` is unused (deadcode)
18:09:54 func genericTestGetCPUDetails(t *testing.T, validVendor string, validModel string, validContents string, data []testCPUDetail) {
18:09:54      ^
18:10:07 Build step 'Execute shell' marked build as failure

We need to remove deadcode linter for these generic* items. PR is on the way.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions