This repository was archived by the owner on May 12, 2021. It is now read-only.
kernel: Fix patch ordering#1005
Merged
Merged
Conversation
Author
|
/test |
Contributor
|
@jodh-intel can you please bump version in |
Fix the `build-kernel.sh` script to sort patches correctly. Previously, it relied on `find(1)` for the ordering. However, `find(1)` does not guarantee any ordering of files within a directory. Since the ordering could therefore be "random", it was quite possible for patches to be applied in the wrong order, resulting in conflicts. Fixes: kata-containers#1003. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
jodh-intel
force-pushed
the
fix-patch-ordering
branch
from
5cd4041 to
93da145
Compare
Author
|
@chavafg - done 😄 /test |
chavafg
approved these changes
Apr 8, 2020
amshinde
approved these changes
Apr 8, 2020
Contributor
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the
build-kernel.shscript to sort patches correctly. Previously,it relied on
find(1)for the ordering. However,find(1)does notguarantee any ordering of files within a directory. Since the ordering
could therefore be "random", it was quite possible for patches to be
applied in the wrong order, resulting in conflicts.
Fixes: #1003.
Signed-off-by: James O. D. Hunt james.o.hunt@intel.com