This repository was archived by the owner on Jun 28, 2024. It is now read-only.
backport fixes for 1.10 for sles, centos, fedora and opensuse#2458
Merged
Conversation
devimc
approved these changes
Apr 15, 2020
GabyCT
changed the title
Contributor
|
/test |
We need to update the setup script for SLES to work for SLES 15 SP1. Fixes kata-containers#2373 Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>
In order to enable the openSUSE Leap 15.1 CI, we need to remove the openSUSE cloud repo as this is related with https://bugzilla.suse.com/show_bug.cgi?id=1165519 as well to skip the entropy test. Fixes kata-containers#2352 Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>
openSUSE Leap and SLES does not longer support docker 18.06, they required as a minimum docker 18.09. This PR updates that version without affecting anything, as docker 18.09 in openSUSE and SLES supports devicemapper. Fixes kata-containers#2342 Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>
The patterns-devel-base-devel_basis has conflicts with some packages versions, this PR removes that dependency and replaces for gcc which is able to build kata containers without issues. Fixes kata-containers#2344 Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>
We need to import the gpg keys and disable the gpgcheck from the /yum/repos.d/kubernetes repository as it is not possible to perform the installation of the kubernetes components, this issue is related with kubernetes/kubernetes#60134. Fixes kata-containers#2233 Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>
We need to enable PowerTools repository for CentOS 8 in order to be able to install packages like moreutils, libseccomp-devel, pandoc, etc. Fixes kata-containers#2214 Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>
We need to enable the priority for CentOS Base repository if we want to update CentOS 8 without issues. This PR enables the priority and with that solves the issues that some perl packages can not be installed. Fixes kata-containers#2223 Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>
The python package is not available on CentOS 8. This PR updates that to use python3 which is currently available for CentOS 7 and 8. Fixes kata-containers#2229 Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>
The alien package is not needed so we can remove it. Fixes kata-containers#2231 Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>
smem is only used at ubuntu (metrics CI), however, it is never used in other distributions. This PR removes this package and avoids that we need to enable special repositories or installing in a particular way when it is not available (for example CentOS 8). Fixes kata-containers#2237 Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>
This PR removes non-existing packages for CentOS 8 as also skips the CRI-O installation mainly because of missing packages as dependencies. Fixes kata-containers#2247 Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>
We have seen random failures when we are trying to enable kubernetes repository in Fedora 31. There are some times that the Fedora CI is failing when we try to import the gpgkey from the kubernetes repository (https://packages.cloud.google.com/yum/doc/yum-key.gpg). This PR removes that we install and run kubernetes on Fedora. Fixes kata-containers#2302 Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>
Contributor
Author
|
/test |
This PR performs modifications in order to fix the SLES CI setup scripts. Fixes kata-containers#2380 Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>
If `FORCE_BUILD_QEMU` is set in environment the script that install QEMU will build and install QEMU from source, ignoring cache. Signed-off-by: Julio Montes <julio.montes@intel.com>
Modify scripts that install kata to support PREFIX environment variable, this way installation path can be configurable. Signed-off-by: Julio Montes <julio.montes@intel.com>
This PR enables the repository that is needed for perl-IPC-Run for RHEL. We need to enable this repository as perl-IPC-Run is a dependency for moreutils package and we need moreutils because we are using chronic. Fixes kata-containers#2438 Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>
libbtrfs-dev is needed to build containerd/cri from sources. Fixes: kata-containers#2419. Signed-off-by: Salvador Fuentes <salvador.fuentes@intel.com>
This adds patch package which is needed to build the kernel. Fixes kata-containers#2262 Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>
Contributor
|
/test |
1 similar comment
Contributor
|
/test |
|
Hi @GabyCT - I think this PR is blocked on the following:
We'll need those fixes backported into the 1.10 packaging branch before this PR will reliably build I think. |
jodh-intel
approved these changes
Apr 16, 2020
chavafg
added a commit
to chavafg/runtime-1
that referenced
this pull request
Apr 16, 2020
Update golang to 1.13.9 in versions.yaml. In addition, add same golang version to `.travis.yml` and delete the call to `.ci/install_go.sh` as it started to cause problems in travis CI. Depends-on: github.com/kata-containers/tests#2458 Fixes: kata-containers#2592. Signed-off-by: Salvador Fuentes <salvador.fuentes@intel.com>
GabyCT
force-pushed
the
updatestable1.10
branch
from
be1d895 to
0816c0f
Compare
Contributor
Author
|
/test |
Add libpmem as build dependency to QEMU. According to QEMU's nvdimm documentation: When 'pmem' is 'on' and QEMU is built with libpmem support, QEMU will take necessary operations to guarantee the persistence of its own writes to the vNVDIMM backend. fixes kata-containers#2340 Signed-off-by: Julio Montes <julio.montes@intel.com>
To build the kernel we need patch command, this PR includes patch as a dependency. Fixes kata-containers#2409 Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>
Currently the jenkins url variable seems empty as we need to first make the source of that variable from lib.sh. Fixes kata-containers#2161 Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>
With golang updated to v1.13, we found golangci-lint build error on ARM CI. Taking advices here( filecoin-project/venus#3486 (comment)), we need to update golangci-lint to v1.18.0 to get Go 1.13 support. Fixes: kata-containers#2434 Depends-on: github.com/kata-containers/runtime#2619 Signed-off-by: Penny Zheng <penny.zheng@arm.com>
Recently, We have updated Go to v1.13.x in kata, and the go compiler in travis ci testing environment should follow this update too. Fixes: kata-containers#2434 Signed-off-by: Penny Zheng <penny.zheng@arm.com>
Contributor
Author
|
@chavafg so it seems something is missing with ginkgo |
Contributor
Author
|
/test |
Call to `tests.KataInit` in `TestMain` to support golang 1.13. Signed-off-by: Julio Montes <julio.montes@intel.com>
Call to `tests.KataInit` in `TestMain` to support golang 1.13. Signed-off-by: Julio Montes <julio.montes@intel.com>
All docker tests are using the 'DefaultHypervisor' (a.k.a 'qemu') as the key when reading from KataConfig. This will cause test failures for the tests requires information from the configuration file (e.g. cpu_test, mem_test and vsock_test) when kata is not using qemu as its hypervisor. This patch introduced a new global variable 'KataHypervisor' which is initialized based on the environment variable 'KATA_HYPERVISOR' that should be set by the CI script. Fixes: kata-containers#2383 Signed-off-by: Bo Chen <chen.bo@intel.com>
Since golang 1.13 packages that call flag.Parse during package initialization may cause tests to fail[1]. Add a new function named `KataInit` to initialize the tests and parse the command line, this function needs to be called as soon as possible, preferably from `TestMain`. [1] - https://golang.org/doc/go1.13#testing fixes kata-containers#2195 Signed-off-by: Julio Montes <julio.montes@intel.com>
Contributor
Author
|
/test |
1 similar comment
Contributor
|
/test |
Performing a dnf -y update on a fedora container 31 is failing as it is complaining about a missing rpm package. This PR removes the option to use latest Fedora and use Fedora 30 which shows a stable behaviour. Fixes kata-containers#2359 Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>
In order to avoid random timeouts, docker images must be pulled before running `docker run` fixes kata-containers#2366 Signed-off-by: Julio Montes <julio.montes@intel.com>
Contributor
Author
|
/test |
1 similar comment
Contributor
Author
|
/test |
GabyCT
force-pushed
the
updatestable1.10
branch
from
9529951 to
5ea41e1
Compare
Contributor
Author
|
/test |
Enhances the `install_cri_containerd.sh` script to be able to build and install containerd using a commit SHA as the version. The script should now work when containerd versions are: - a release number, e.g. `v1.3.3` - a commit SHA, e.g. `3a4acfbc99aa976849f51a8edd4af20ead51d8d7` Fixes: kata-containers#2414. Signed-off-by: Salvador Fuentes <salvador.fuentes@intel.com>
containerd cannot be build with seccomp enabled in Opensuse 15, and trying to remove `seccomp` from `BUILDTAGS` variable is not working correctly. Skip tests while investigation continues. Related: kata-containers#1251 Signed-off-by: Salvador Fuentes <salvador.fuentes@intel.com>
Contributor
Author
|
/test |
Currently the CI fails when cloud-hypervisor (CLH) is being used. This is because kata-runtime is only set as default/new Docker runtime when QEMU is being used. Fixes: kata-containers#2189 Signed-off-by: Bo Chen <chen.bo@intel.com>
Contributor
Author
|
/test |
With the fix on issue kata-containers#2383, we got a regression on the vsock_test with CI on firecracker. The test was silently skipped because the 'DefaultHypervisor' (a.k.a 'qemu') was used as the key to read Kata configuration even when 'firecracker' should be used as the key. With the wrong key, the 'KataConfig.Hypervisor[KataHypervisor].Vsock' is 'false' making the test silently skipped, while the test is not skipping and failing with the right key. As a temporary work-around, we need to disable the test first. Fixes: kata-containers#2397 Signed-off-by: Bo Chen <chen.bo@intel.com>
jodh-intel
pushed a commit
to jodh-intel/tests-1
that referenced
this pull request
Apr 22, 2020
kata guest only supports cgroupfs as cgroup manager. And recently, cri-o has raised a PR to switch its default cgroup manager from cgroupfs to systemd. So here, we need to switch it back. Fixes: kata-containers#2304 Depends-on: github.com/kata-containers/runtime/kata-containers#2458 Signed-off-by: Penny Zheng <penny.zheng@arm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
e878226 ci: Skip vsock_test for firecracker
70fd2df ci: Set kata-runtime as Docker runtime when using cloud-hypervisor
9529951 containerd-shimv2: do not run under opensuse 15
465f340 containerd: be able to build from source when version is a commit
c801eb1 integration/docker: pull fedora 30 image before using it
2e82e76 test: Update package manager test for Fedora
6ef2f29 tests: don't call to flag.Parse() from init()
51d7086 test:docker: Use the right hypervisor when reading from KataConfig
9077fdc functional: fix functional tests to support golang 1.13
b73b5b0 integration/docker: fix docker integration tests to support golang 1.13
be1d895 travis: specify go version with the latest v1.13.x
6d1f4e7 golangci-lint: fix
invalid pseudo-versionerror83f1a46 ci: Fix cloud hypervisor script
af866c6 ci: Add patch as a dependency
5cf802b ci: add libpmem as build dependency
9e2c50d ci: Add patch package
d1f77f4 debian: Install libbtrfs-dev package
ed55c8f ci: Enable repo for perl-IPC-Run
734f3cd ci: Add PREFIX variable
21b78e6 ci: Add FORCE_BUILD_QEMU variable
4b9ed65 ci: Fix SLES CI
102f9ba ci: Do not install and run kubernetes on Fedora
6c92f02 ci: Enable ci for CentOS8
d6a895a ci: Remove smem package
38b9c25 ci: Remove alien package
376a6a6 ci: Update python for CentOS 8
c01f3ca ci: Enable priority for CentOS base repository
d69d58c ci: Enable PowerTools repository for CentOS 8
958b12e ci: Fix kubernetes installation for Fedora 31
ac63c13 ci: Update build tools package dependency for openSUSE Leap
afc16d9 ci: Update docker version for openSUSE and SLES
733f052 ci: Enable openSUSE Leap 15.1 CI
d77639f ci: Update setup script for SLES