This repository was archived by the owner on May 12, 2021. It is now read-only.
obs: let patch set in order before apply them#1016
Merged
Conversation
jodh-intel
approved these changes
Apr 16, 2020
jodh-intel
left a comment
jodh-intel
left a comment
There was a problem hiding this comment.
Thanks @jongwu and good catch! 😄!
| @@ -1 +1 @@ | |||
| 72 | |||
| 73 | |||
There was a problem hiding this comment.
Nit: I don't think this is strictly necessary since you are not changing any (other) files below kernel/* here.
Contributor
Author
There was a problem hiding this comment.
ok, I will change it back.
obs ci for linuxcontainer will fail when apply patch set which have dependency within. so patch set should be made in order before feed to apply. Fixes: kata-containers#1015 Signed-off-by: Jianyong Wu <jianyong.wu@arm.com>
|
Thanks @jongwu. /test |
|
/AzurePipelines run |
devimc
approved these changes
Apr 16, 2020
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
Author
|
hi @devimc @jodh-intel any comments? |
|
@jongwu thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
obs ci for linuxcontainer will fail when apply patch set which have
dependency within. so patch set should be made in order before feed
to apply.
Fixes: #1015
Signed-off-by: Jianyong Wu jianyong.wu@arm.com
@grahamwhaley @jodh-intel