Adding: Firecracker Client API Support#1026
Conversation
| name = "github.com/go-openapi/runtime" | ||
| revision = "aadb2cc7b8862fdab251bf60a8b9d2a951c9746c" | ||
|
|
||
|
|
There was a problem hiding this comment.
Nit: Please remove the extra blank line.
sboeuf
left a comment
sboeuf
left a comment
There was a problem hiding this comment.
Looks good, just two nits regarding Gopkg.toml.
One global comment regarding the last commit, I think it'd be worth it to explain why firecracker requires those packages and where they're specified. Because looking at the generated client code is not very obvious and convenient :)
mcastelino
force-pushed
the
topic/firecracker-enable
branch
from
3402194 to
f60a367
Compare
Add firecracker swagger definition v2.0 retrieved from https://github.com/firecracker-microvm/firecracker-go-sdk/blob/master/client/swagger.yaml at 840c1e37f5f2bbcbff1fdbfcfcea09d0bf158977 This will be used to generate the client code. Fixes: kata-containers#284 Signed-off-by: Manohar Castelino <manohar.r.castelino@intel.com>
Generate the firecracker models using swagger ``` swagger generate model -f ./swagger.yaml --model-package=client/models --client-package=client ``` Signed-off-by: Manohar Castelino <manohar.r.castelino@intel.com>
Add the generated operator and client code to interact with firecracker. The code is generated using the command ``` swagger generate client -f ./swagger.yaml --model-package=client/models --client-package=client ``` Signed-off-by: Manohar Castelino <manohar.r.castelino@intel.com>
Vendor in packages required by firecracker. Signed-off-by: Manohar Castelino <manohar.r.castelino@intel.com>
mcastelino
force-pushed
the
topic/firecracker-enable
branch
from
f60a367 to
a22f9ef
Compare
|
What's the relationship between this package and the FC client offered by aws team (https://github.com/firecracker-microvm/firecracker-go-sdk)? Is the official one missing some key functionality for us to use? |
|
Looks fine, but you'll need to add some license headers to the added file (see travis-ci failure). |
I have same question with @bergwolf , can we just vendor firecracker client and re-use it? |
|
We could just exclude the licence checks from the auto-generated |
|
Closing this in favor of #1044 |
6 participants
Adding the firecracker client API support. This is in preparation of firecracker support in Kata containers.
This includes the swagger definition, auto generated code and the vendoring of packages required by this code.
This does not include the actual implementation of the hypervisor interface which will be done in subsequent commit.