Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

store: Add SetLogger API#1298

Merged
devimc merged 1 commit into
kata-containers:masterfrom
jodh-intel:store-pkg-add-SetLogger
Feb 28, 2019
Merged

store: Add SetLogger API#1298
devimc merged 1 commit into
kata-containers:masterfrom
jodh-intel:store-pkg-add-SetLogger

Conversation

@jodh-intel
Copy link
Copy Markdown

Add a store.SetLogger() API to allow the store package to log with the standard set of fields (as expected by the log parser [1].

Fixes #1297.


[1] - https://github.com/kata-containers/tests/tree/master/cmd/log-parser#logfile-requirements

Signed-off-by: James O. D. Hunt james.o.hunt@intel.com

Add a `store.SetLogger()` API to allow the store package to log with the
standard set of fields (as expected by the log parser [1].

Fixes kata-containers#1297.

---

[1] - https://github.com/kata-containers/tests/tree/master/cmd/log-parser#logfile-requirements

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
@grahamwhaley grahamwhaley requested a review from sameo February 28, 2019 10:59
@jodh-intel
Copy link
Copy Markdown
Author

@sameo - please could you check to see if #1208 and #1233 need similar updates?

Copy link
Copy Markdown
Contributor

@grahamwhaley grahamwhaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@grahamwhaley
Copy link
Copy Markdown
Contributor

/test

@devimc devimc merged commit dbfd965 into kata-containers:master Feb 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants