Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

clh: Disable the 'seccomp' option temporarily #2900

Merged
jcvenegas merged 1 commit into from
Aug 26, 2020
Merged

clh: Disable the 'seccomp' option temporarily #2900

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions virtcontainers/clh.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -955,6 +955,12 @@ func (clh *cloudHypervisor) LaunchClh() (string, int, error) {
args = append(args, "-vv")
}

// Disable the 'seccomp' option in clh for now.
// In this way, we can separate the periodic failures caused
// by incomplete `seccomp` filters from other failures.
// We will bring it back after completing the `seccomp` filter.
Copy link
Copy Markdown

@devimc devimc Aug 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you mind filing an issue and mentioning it here ?

Copy link
Copy Markdown
Contributor Author

@likebreath likebreath Aug 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The corresponding issue is here: #2899.

I will open another one to track the work on collecting seccomp filter lists based on kata's CI workload.

Copy link
Copy Markdown
Contributor Author

@likebreath likebreath Aug 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devimc The other issue added here: #2901. :)

Copy link
Copy Markdown

@jodh-intel jodh-intel Aug 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @likebreath. Please can you add the issue URLs into the code comments so we don't forget :)

args = append(args, "--seccomp", "false")

clh.Logger().WithField("path", clhPath).Info()
clh.Logger().WithField("args", strings.Join(args, " ")).Info()

Expand Down