This repository was archived by the owner on May 12, 2021. It is now read-only.
clh: Disable the 'seccomp' option temporarily#2900
Merged
Conversation
Contributor
Author
|
/test-clh |
We kept observing instabilities from CLH CI jobs periodically. To separate the random failures caused by `seccomp` from other failures, this patch disables the 'seccomp' option from clh in kata for now. We will bring this option back after completing the 'seccomp' filter lists based on Kata's CI workload. Fixes: kata-containers#2899 Signed-off-by: Bo Chen <chen.bo@intel.com>
devimc
reviewed
Aug 25, 2020
devimc
left a comment
devimc
left a comment
There was a problem hiding this comment.
thanks @likebreath - lgtm - just one nit
| // Disable the 'seccomp' option in clh for now. | ||
| // In this way, we can separate the periodic failures caused | ||
| // by incomplete `seccomp` filters from other failures. | ||
| // We will bring it back after completing the `seccomp` filter. |
There was a problem hiding this comment.
would you mind filing an issue and mentioning it here ?
Contributor
Author
There was a problem hiding this comment.
The corresponding issue is here: #2899.
I will open another one to track the work on collecting seccomp filter lists based on kata's CI workload.
Contributor
Author
There was a problem hiding this comment.
Thanks @likebreath. Please can you add the issue URLs into the code comments so we don't forget :)
likebreath
added a commit
to likebreath/kata-tests
that referenced
this pull request
Aug 25, 2020
Again this is a dummy PR to the test repo, and is used to validate the changes to another PR from the packaging PR related to cloud-hypervisor. The following linked issue is just a place holder. Depends-on: github.com/kata-containers/packaging#1099 Depends-on: github.com/kata-containers/runtime#2900 Fixes: kata-containers#2546 Signed-off-by: Bo Chen <chen.bo@intel.com>
Contributor
Author
|
/test-ubuntu |
Codecov Report
@@ Coverage Diff @@
## master #2900 +/- ##
=======================================
Coverage 51.44% 51.44%
=======================================
Files 118 118
Lines 17427 17428 +1
=======================================
+ Hits 8965 8966 +1
Misses 7379 7379
Partials 1083 1083 |
devimc
approved these changes
Aug 26, 2020
jcvenegas
approved these changes
Aug 26, 2020
likebreath
added
the
port-to-2.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We kept observing instabilities from CLH CI jobs periodically. To
separate the random failures caused by
seccompfrom other failures,this patch disables the 'seccomp' option from clh in kata for now. We
will bring this option back after completing the 'seccomp' filter lists
based on Kata's CI workload.
Fixes: #2899
Signed-off-by: Bo Chen chen.bo@intel.com