Skip to content
This repository was archived by the owner on Jun 28, 2024. It is now read-only.

ci: install parted in debian#1099

Merged
chavafg merged 1 commit into
kata-containers:masterfrom
devimc:topic/debianPartprobe
Feb 5, 2019
Merged

ci: install parted in debian#1099
chavafg merged 1 commit into
kata-containers:masterfrom
devimc:topic/debianPartprobe

Conversation

@devimc
Copy link
Copy Markdown

@devimc devimc commented Jan 29, 2019

partprobe command is required to build the image

fixes #1098

Signed-off-by: Julio Montes julio.montes@intel.com

ci: install parted in debian
17d0583 
partprobe command is required to build the image

fixes kata-containers#1098

Signed-off-by: Julio Montes <julio.montes@intel.com>
@devimc devimc requested a review from GabyCT January 29, 2019 20:36
GabyCT
GabyCT approved these changes Jan 29, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@GabyCT GabyCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@devimc
Copy link
Copy Markdown
Author

devimc commented Jan 29, 2019

/test

@jodh-intel
Copy link
Copy Markdown

jodh-intel commented Jan 30, 2019 •
edited by amshinde
Loading

lgtm

Restarted Fedora CI (http 503 error), along with the Fedora vsock CI which fell over for reasons unknown:

20:55:35 [kata-containers-tests-fedora-vsocks-PR] $ /bin/bash /tmp/jenkins6853380809490839401.sh
20:55:35 /tmp/jenkins/workspace/kata-containers-tests-fedora-vsocks-PR/artifacts /tmp/jenkins/workspace/kata-containers-tests-fedora-vsocks-PR/go/src/github.com/kata-containers/tests
20:55:37 .ci/setup.sh: line 43:  9953 Terminated              "${cidir}/../cmd/container-manager/manage_ctr_mgr.sh" docker install -f

Approved with PullApprove

grahamwhaley
grahamwhaley approved these changes Jan 30, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@grahamwhaley grahamwhaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@grahamwhaley
Copy link
Copy Markdown
Contributor

grahamwhaley commented Jan 30, 2019

OK, there is weird ... pullapprove is denying your SoB on your single commit - says you need 'no SoB on 0 commits'... it is borked.
I'll nudge the vsocks CI if needed - but otherwise we will probably need to force merge this (the broken ARM CI is a known thing)

@jodh-intel
Copy link
Copy Markdown

jodh-intel commented Jan 31, 2019

I managed to fix the pullapprove issue by logging into PA and "syncing PR". :gremlins:...

@chavafg
Copy link
Copy Markdown
Contributor

chavafg commented Feb 5, 2019

CI passed and 3 acks here, so merging this change.

@chavafg chavafg merged commit 9272e68 into kata-containers:master Feb 5, 2019
likebreath added a commit to likebreath/kata-tests that referenced this pull request Jul 22, 2020
@likebreath
clh: test PR kata-containers#1099 from kata-containers/packaging
0b60037 
Again this is a dummy PR to the test repo, and is used to validate the
changes to another PR from the packaging PR related to
cloud-hypervisor. The following linked issue is just a place holder.

Depends-on: github.com/kata-containers/packaging#1099

Fixes: kata-containers#2546

Signed-off-by: Bo Chen <chen.bo@intel.com>
likebreath added a commit to likebreath/kata-tests that referenced this pull request Jul 22, 2020
@likebreath
clh: test PR kata-containers#1099 from kata-containers/packaging
8962f53 
Again this is a dummy PR to the test repo, and is used to validate the
changes to another PR from the packaging PR related to
cloud-hypervisor. The following linked issue is just a place holder.

Depends-on: github.com/kata-containers/packaging#1099

Fixes: kata-containers#2546

Signed-off-by: Bo Chen <chen.bo@intel.com>
likebreath added a commit to likebreath/kata-tests that referenced this pull request Jul 22, 2020
@likebreath
clh: test PR kata-containers#1099 from kata-containers/packaging
9fddc0e 
Again this is a dummy PR to the test repo, and is used to validate the
changes to another PR from the packaging PR related to
cloud-hypervisor. The following linked issue is just a place holder.

Depends-on: github.com/kata-containers/packaging#1099

Fixes: kata-containers#2546

Signed-off-by: Bo Chen <chen.bo@intel.com>
likebreath added a commit to likebreath/kata-tests that referenced this pull request Jul 28, 2020
@likebreath
clh: test PR kata-containers#1099 from kata-containers/packaging
0e125c0 
Again this is a dummy PR to the test repo, and is used to validate the
changes to another PR from the packaging PR related to
cloud-hypervisor. The following linked issue is just a place holder.

Depends-on: github.com/kata-containers/packaging#1099

Fixes: kata-containers#2546

Signed-off-by: Bo Chen <chen.bo@intel.com>
likebreath added a commit to likebreath/kata-tests that referenced this pull request Aug 13, 2020
@likebreath
clh: test PR kata-containers#1099 from kata-containers/packaging
28f93ca 
Again this is a dummy PR to the test repo, and is used to validate the
changes to another PR from the packaging PR related to
cloud-hypervisor. The following linked issue is just a place holder.

Depends-on: github.com/kata-containers/packaging#1099

Fixes: kata-containers#2546

Signed-off-by: Bo Chen <chen.bo@intel.com>
likebreath added a commit to likebreath/kata-tests that referenced this pull request Aug 13, 2020
@likebreath
clh: test PR kata-containers#1099 from kata-containers/packaging
7f799ee 
Again this is a dummy PR to the test repo, and is used to validate the
changes to another PR from the packaging PR related to
cloud-hypervisor. The following linked issue is just a place holder.

Depends-on: github.com/kata-containers/packaging#1099

Fixes: kata-containers#2546

Signed-off-by: Bo Chen <chen.bo@intel.com>
likebreath added a commit to likebreath/kata-tests that referenced this pull request Aug 14, 2020
@likebreath
clh: test PR kata-containers#1099 from kata-containers/packaging
b86098d 
Again this is a dummy PR to the test repo, and is used to validate the
changes to another PR from the packaging PR related to
cloud-hypervisor. The following linked issue is just a place holder.

Depends-on: github.com/kata-containers/packaging#1099

Fixes: kata-containers#2546

Signed-off-by: Bo Chen <chen.bo@intel.com>
likebreath added a commit to likebreath/kata-tests that referenced this pull request Aug 25, 2020
@likebreath
clh: test PR kata-containers#1099 from kata-containers/packaging
46f219c 
Again this is a dummy PR to the test repo, and is used to validate the
changes to another PR from the packaging PR related to
cloud-hypervisor. The following linked issue is just a place holder.

Depends-on: github.com/kata-containers/packaging#1099

Fixes: kata-containers#2546

Signed-off-by: Bo Chen <chen.bo@intel.com>
likebreath added a commit to likebreath/kata-tests that referenced this pull request Aug 25, 2020
@likebreath
clh: test PR kata-containers#1099 from kata-containers/packaging
8d777e0 
Again this is a dummy PR to the test repo, and is used to validate the
changes to another PR from the packaging PR related to
cloud-hypervisor. The following linked issue is just a place holder.

Depends-on: github.com/kata-containers/packaging#1099

Fixes: kata-containers#2546

Signed-off-by: Bo Chen <chen.bo@intel.com>
likebreath added a commit to likebreath/kata-tests that referenced this pull request Aug 25, 2020
@likebreath
clh: test PR kata-containers#1099 from kata-containers/packaging
f8dc793 
Again this is a dummy PR to the test repo, and is used to validate the
changes to another PR from the packaging PR related to
cloud-hypervisor. The following linked issue is just a place holder.

Depends-on: github.com/kata-containers/packaging#1099
Depends-on: github.com/kata-containers/runtime#2899

Fixes: kata-containers#2546

Signed-off-by: Bo Chen <chen.bo@intel.com>
likebreath added a commit to likebreath/kata-tests that referenced this pull request Aug 25, 2020
@likebreath
clh: test PR kata-containers#1099 from kata-containers/packaging
6c45a15 
Again this is a dummy PR to the test repo, and is used to validate the
changes to another PR from the packaging PR related to
cloud-hypervisor. The following linked issue is just a place holder.

Depends-on: github.com/kata-containers/packaging#1099
Depends-on: github.com/kata-containers/runtime#2900

Fixes: kata-containers#2546

Signed-off-by: Bo Chen <chen.bo@intel.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@grahamwhaley grahamwhaley grahamwhaley approved these changes

@chavafg chavafg chavafg approved these changes

@GabyCT GabyCT GabyCT approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ci: debian: partprobe: command not found

5 participants

@devimc @jodh-intel @grahamwhaley @chavafg @GabyCT