This repository was archived by the owner on May 12, 2021. It is now read-only.
create/run: Make bundle path default to cwd#838
Merged
grahamwhaley merged 2 commits intoNov 22, 2018
Merged
Conversation
|
/test |
1 similar comment
Member
|
/test |
Member
|
/retest |
jodh-intel
force-pushed
the
stable-1.3-fix-default-bundle-path
branch
from
bd30104 to
4b1dbff
Compare
Author
|
/test |
This was referenced Oct 25, 2018
Author
|
Blocked on kata-containers/tests#856. |
bergwolf
approved these changes
Oct 29, 2018
|
@jodh-intel kata-containers/tests#856 has been merged, do you think the CI should pass now for this PR? Nevermind, I've just read #836 (comment) |
|
@jodh-intel any progress on that? |
added 2 commits
November 22, 2018 14:24
Re-ordered a couple of structs (moved `sync.WaitGroup` fields) to keep the `maligned` linter happy. Previously: `` virtcontainers/pkg/mock/cc_proxy_mock.go:24:18:warning: struct of size 160 could be 152 (maligned) virtcontainers/monitor.go:15:14:warning: struct of size 80 could be 72 (maligned) ``` Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com> (cherry picked from part of commit 526d55b)
The bundle path was documented as defaulting to the current directory but was not being set to that value if not explicitly specified. Also moved factory creation code to a new `handleFactory()` function to avoid cyclomatic complexity issues. Fixes kata-containers#821. (cherry picked from commit 8831245) Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
jodh-intel
force-pushed
the
stable-1.3-fix-default-bundle-path
branch
from
4b1dbff to
dbd78da
Compare
Author
|
Ping - would be good to get this landed at long last ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bundle path was documented as defaulting to the current directory
but was not being set to that value if not explicitly specified.
Also moved factory creation code to a new
handleFactory()function toavoid cyclomatic complexity issues.
Fixes #821.
(cherry picked from commit 8831245)
Signed-off-by: James O. D. Hunt james.o.hunt@intel.com