versions: Add xurls utility#855
Conversation
grahamwhaley
left a comment
There was a problem hiding this comment.
I think pinning this, particularly for older stable branches (so they don't rot as the tools move forwards), is the right thing to do...
lgtm
|
This fix will allow the tests CI to be updated to install the correct version of xurls for a particular stable branch. However, this YAML could arguably could be added the tests versions database instead: Either way, we need to use a pinned version of xurls in the stable branches to fix the CI failures on these PRs: ... or we have to backport the golang 1.10.4 fix to all stable branches: @egernst, @gnawux, @grahamwhaley, @chavafg - any thoughts on what the best approach is here? |
|
The principle of backports to stable branches for new versions of golang (be that in our code or code and tools we import), feels wrong. They are stable, so we should not be injecting a bunch of flux. |
Add the [`xurls`](https://mvdan.cc/xurls/cmd/xurls) utility to the versions database. This tool is used by the CI scripts in the `tests` repo to check URLs for validity. However, the latest version of `xurls` requires golang 1.10.3+, but we don't need to use the latest version and doing so is causing us problems (see kata-containers/kata-containers#32). Fixes kata-containers#854. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
5055011 to
bf4782f
Compare
|
@jodh-intel I would prefer that this xurls version should go in the versions.yaml of the tests repository as it is a tool only used for testing purposes. |
|
@chavafg - wfm. I'll close this PR and probably handle it on kata-containers/tests#856... |
Handle PCI paths consistently and more generally
Add the
xurlsutility to theversions database. This tool is used by the CI scripts in the
testsrepo to check URLs for validity. However, the latest version of
xurlsrequires golang 1.10.3+, but we don't need to use the latest version and
doing so is causing us problems (see
kata-containers/kata-containers#32).
Fixes #854.
Signed-off-by: James O. D. Hunt james.o.hunt@intel.com