This repository was archived by the owner on Jun 28, 2024. It is now read-only.
ci: replace $TRAVIS with $GITHUB_ACTION in setup#5518
Merged
Conversation
TRAVIS is not used for CI by kata-containers, and we're in the process of removing TRAVIS variables from the environment. The GITHUB_ACTION variable is defined by github actions by default ([1]) and it has the desired semantics when checked here (only install a minimal set of extra packages). I wanted to use $CI but that is also set on jenkins through .ci/ci_job_flags.sh, and jenkins jobs do not work with the minimal setup. [1]: https://docs.github.com/en/actions/learn-github-actions/variables#default-environment-variables) Fixes: kata-containers#3544 Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
These are not used any longer. Fixes: kata-containers#3544 Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
jepio
force-pushed
the
jepio/remove-travis
branch
from
947da85 to
f644f65
Compare
katacontainersbot
added
size/small
Member
Author
|
/test |
jepio
force-pushed
the
jepio/remove-travis
branch
from
f644f65 to
6aa2684
Compare
jepio
changed the title
Member
Author
|
/test |
fidencio
approved these changes
Mar 9, 2023
GabyCT
approved these changes
Mar 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nothing else relies on
TRAVIS,GITHUB_ACTIONcan be checked for the same purpose and is defined by gh-actions.Contrary to what one might think,
CIis not a suitable variable to check because it is set by jenkins as well, but jenkins requires the installation of the full package set.See: kata-containers/kata-containers#3544