Skip to content
This repository was archived by the owner on Jun 28, 2024. It is now read-only.

CC | ci: replace $TRAVIS with $GITHUB_ACTION in setup#5532

Merged
stevenhorsman merged 2 commits into
kata-containers:CCv0from
jepio:jepio/remove-travis
Mar 17, 2023
Merged

CC | ci: replace $TRAVIS with $GITHUB_ACTION in setup#5532
stevenhorsman merged 2 commits into
kata-containers:CCv0from
jepio:jepio/remove-travis

Conversation

@jepio
Copy link
Copy Markdown
Member

@jepio jepio commented Mar 16, 2023 •
edited
Loading

jepio added 2 commits March 16, 2023 15:17
@jepio
ci: replace $TRAVIS with $GITHUB_ACTION in setup
57c3785 
TRAVIS is not used for CI by kata-containers, and we're in the process of
removing TRAVIS variables from the environment. The GITHUB_ACTION variable is
defined by github actions by default ([1]) and it has the desired semantics
when checked here (only install a minimal set of extra packages).

I wanted to use $CI but that is also set on jenkins through
.ci/ci_job_flags.sh, and jenkins jobs do not work with the minimal setup.

[1]: https://docs.github.com/en/actions/learn-github-actions/variables#default-environment-variables)

Fixes: kata-containers#3544
Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
@jepio
workflows: Remove TRAVIS variable definitions
a99f765 
These are not used any longer.

Fixes: kata-containers#3544
Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
@jepio jepio requested review from GabyCT and fidencio March 16, 2023 14:20
@jepio jepio mentioned this pull request Mar 16, 2023
Closed
@katacontainersbot katacontainersbot added the size/small Small and simple task label Mar 16, 2023
@stevenhorsman
Copy link
Copy Markdown
Member

stevenhorsman commented Mar 16, 2023

/test

stevenhorsman
stevenhorsman approved these changes Mar 16, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

fidencio
fidencio approved these changes Mar 16, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @jepio!

@stevenhorsman
Copy link
Copy Markdown
Member

stevenhorsman commented Mar 16, 2023

SEV test failed with:

16:07:42 Install Kubernetes components
16:07:42 Warning: apt-key output should not be parsed (stdout is not a terminal)
16:07:42 gpg: no valid OpenPGP data found.
16:07:42 [install_kubernetes.sh:32] ERROR: sudo apt-key add -
16:07:42 [jenkins_job_build.sh:251] ERROR: .ci/setup.sh
16:07:42 ++ handle_error 93
16:07:42 ++ local exit_code=2
16:07:42 ++ local line_number=93
16:07:42 ++ echo 'Failed at /home/jenkins/workspace/tests-CCv0-ubuntu-20.04_sev-x86_64-CC_SEV_CRI_CONTAINERD_K8S-PR/ci_entry_point.sh +93: .ci/jenkins_job_build.sh "${repo_to_test}" -t "${TEST_TYPE}"'
16:07:42 Failed at /home/jenkins/workspace/tests-CCv0-ubuntu-20.04_sev-x86_64-CC_SEV_CRI_CONTAINERD_K8S-PR/ci_entry_point.sh +93: .ci/jenkins_job_build.sh "${repo_to_test}" -t "${TEST_TYPE}"
16:07:42 ++ exit 2

/test-sev

@jepio
Copy link
Copy Markdown
Member Author

jepio commented Mar 17, 2023

That must have been a packages.cloud.google.com outage again, because I had already restarted a run before that, that failed with:

15:58:33 Err:5 https://packages.cloud.google.com/apt kubernetes-xenial-unstable Release
15:58:33 Certificate verification failed: The certificate is NOT trusted. The certificate issuer is unknown. Could not handshake: Error in the certificate verification. [IP: 142.250.188.14 443]

Rerunning.

@jepio
Copy link
Copy Markdown
Member Author

jepio commented Mar 17, 2023

/test-sev

@stevenhorsman
Copy link
Copy Markdown
Member

stevenhorsman commented Mar 17, 2023

Only TDX is failing, which is a known issue, so we can merge this. Thanks @jepio!

@stevenhorsman stevenhorsman merged commit 67cb606 into kata-containers:CCv0 Mar 17, 2023
@jepio jepio deleted the jepio/remove-travis branch March 17, 2023 09:14
@jepio jepio mentioned this pull request Mar 20, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@fidencio fidencio fidencio approved these changes

@GabyCT GabyCT GabyCT approved these changes

@stevenhorsman stevenhorsman stevenhorsman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/small Small and simple task

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jepio @stevenhorsman @fidencio @GabyCT @katacontainersbot