Fix integration test failures#151
Merged
MrCreosote merged 1 commit intodevelopfrom Jul 26, 2022
Merged
Conversation
The tests were starting before the RE API was up. I hypothesize this explains the 1 pass / 1 fail pattern - the first test would fail because the server wasn't up, and the step that takes the server down wouldn't run. The next set of tests would pass, and take the server down, and so on and so forth.
ghost
reviewed
Jul 26, 2022
| * Merge from Develop to Main | ||
| * Draft a release using semantic versioning (e.g 1.2.3) by creating a tag with the target of Main | ||
| * Ensure release notes are updated manually and/or by AutoGenerate Release Notes | ||
|
|
Member
Author
There was a problem hiding this comment.
Sorry, I don't understand - there's nothing removed here?
| # run importer/, relation_engine_server/, and spec/ tests | ||
| coverage run --branch -m pytest | ||
| # RE client tests | ||
| # RE client tests - seemss like these tests were already run in the line above, why run them again? |
Member
Author
There was a problem hiding this comment.
Got it fixed locally, it'll show up in my next PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests were starting before the RE API was up. I hypothesize this explains
the 1 pass / 1 fail pattern - the first test would fail because the server
wasn't up, and the step that takes the server down wouldn't run. The next set
of tests would pass, and take the server down, and so on and so forth.
Closes #105
For changes to the codebase: