Skip to content

Fix integration test failures #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MrCreosote merged 1 commit into from
Jul 26, 2022
Merged

Fix integration test failures #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,3 +49,10 @@ The CI service is available in the `relationapi` service
* Merge from Develop to Main
* Draft a release using semantic versioning (e.g 1.2.3) by creating a tag with the target of Main
* Ensure release notes are updated manually and/or by AutoGenerate Release Notes

Copy link
Copy Markdown

@ghost ghost Jul 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait why is this removed?

Copy link
Copy Markdown
Member Author

@MrCreosote MrCreosote Jul 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I don't understand - there's nothing removed here?

Copy link
Copy Markdown

@ghost ghost Jul 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. JK

## Testing

To run tests:
```
make test
```
4 changes: 3 additions & 1 deletion scripts/run_tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,10 @@ sh /app/scripts/start_server.sh &
coverage erase
# spec validation
python -m spec.validate
# wait for the RE service to be up so integration tests can pass
python -m relation_engine_server.utils.wait_for api
# run importer/, relation_engine_server/, and spec/ tests
coverage run --branch -m pytest
# RE client tests
# RE client tests - seemss like these tests were already run in the line above, why run them again?
Copy link
Copy Markdown
Collaborator

@ialarmedalien ialarmedalien Jul 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo - seems

Copy link
Copy Markdown
Member Author

@MrCreosote MrCreosote Jul 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it fixed locally, it'll show up in my next PR

PYTHONPATH=client_src python -m pytest client_src/test
coverage html --omit=*/test_*