Improve error handling and propagation#79
Merged
yuvipanda merged 3 commits intokbatch-dev:mainfrom Sep 27, 2024
Merged
Conversation
turns lots of user errors from vague 500 into actionable errors e.g. 404 not found, invalid names, configmaps too big, etc.
show only the status and error message
This was referenced Sep 27, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
create_namespaced_jobAs a result, invalid input like
goes from producing large amounts of output with no actionable info because of a generic 500 error and traceback:
to a short(-ish, depending on the kubernetes error), actionable error:
This is especially improved for 404s, where
kbatch pod logs nosuchpodwould produce the same big 500 traceback, but now gets the short and clear:I'd say this closes #52 . I don't think we need to support names k8s doesn't, and this gives users the right error to know what they need to change.