Conversation
allows getting logs by job name, which is usually what folks have rather than needing to do job -> pod lookup
Contributor
Author
|
alternative to this: replace pod logs with job logs, since that's more like what folks are going to want. But maybe jobs can have more than one pod? |
Contributor
Author
|
I don't think |
Collaborator
|
Yes, adding this as an addition instead of replacement is the way to go! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allows getting logs by job name, which is usually what folks have
rather than needing to do job -> pod lookup
(draft because no tests yet)
this and #79 together closes #61 where someone is requesting logs for a job name, not a pod name. #79 makes the error more apparent, while this does what is actually expected (logs for a job)