fix(windows): prevent use-after-free crash in Skia bitmap during dispose#199
Merged
kdroidFilter merged 1 commit intomasterfrom Apr 11, 2026
Merged
fix(windows): prevent use-after-free crash in Skia bitmap during dispose#199kdroidFilter merged 1 commit intomasterfrom
kdroidFilter merged 1 commit intomasterfrom
Conversation
asComposeImageBitmap() shares native pixel memory with the source Bitmap. When dispose() closed the double-buffer bitmaps, Compose could still be rendering the last frame on the AWT-EventQueue thread, causing Skia's _nMakeFromBitmap to read freed memory (EXCEPTION_ACCESS_VIOLATION in skiko-windows-x64.dll). Instead of calling close() explicitly, nullify references and let the Skia Managed cleaner free them once all holders (including Compose) drop their references.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EXCEPTION_ACCESS_VIOLATIONinskiko-windows-x64.dll) occurring when playback ends or the player is disposedasComposeImageBitmap()is zero-copy — the resultingImageBitmapshares native pixel memory with the sourceBitmap. Whendispose()calledclose()on the double-buffer bitmaps, Compose could still be rendering the last frame on the AWT-EventQueue thread, causing_nMakeFromBitmapto read freed memoryManagedcleaner free them once all holders (including Compose) drop their references — no memory leak, just ~50ms deferred cleanupTest plan