Skip to content

fix(windows): prevent use-after-free crash in Skia bitmap during dispose #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kdroidFilter merged 1 commit into from
Apr 11, 2026
+8 −20
Merged

fix(windows): prevent use-after-free crash in Skia bitmap during dispose #199

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 8 additions & 20 deletions ...mMain/kotlin/io/github/kdroidfilter/composemediaplayer/windows/WindowsVideoPlayerState.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,19 +346,10 @@ class WindowsVideoPlayerState : VideoPlayerState {

// Free bitmaps and frame buffers
bitmapLock.write {
val currentFrame = _currentFrame
if (currentFrame != null &&
currentFrame !== skiaBitmapA &&
currentFrame !== skiaBitmapB
) {
currentFrame.close()
}
_currentFrame = null
currentFrameState.value = null

// Clean up double-buffering bitmaps
skiaBitmapA?.close()
skiaBitmapB?.close()
// Don't close bitmaps — see comment in releaseAllResources().
skiaBitmapA = null
skiaBitmapB = null
skiaBitmapWidth = 0
Expand Down Expand Up @@ -391,19 +382,16 @@ class WindowsVideoPlayerState : VideoPlayerState {

// Free bitmaps and frame buffers
bitmapLock.write {
val currentFrame = _currentFrame
if (currentFrame != null &&
currentFrame !== skiaBitmapA &&
currentFrame !== skiaBitmapB
) {
currentFrame.close()
}
_currentFrame = null
currentFrameState.value = null

// Clean up double-buffering bitmaps
skiaBitmapA?.close()
skiaBitmapB?.close()
// Do NOT close the double-buffer bitmaps here: the ImageBitmap
// exposed via currentFrameState shares the same native pixel memory
// (asComposeImageBitmap is zero-copy). Compose may still be rendering
// the last frame on the AWT-EventQueue thread. Closing now would free
// the native memory while Skia reads it, causing an access violation.
// Nullifying the references lets the Skia Managed cleaner release them
// once Compose (and any other holder) drops its reference.
skiaBitmapA = null
skiaBitmapB = null
skiaBitmapWidth = 0
Expand Down