fix(mac): apply rotation metadata and reach 100% on progress bar#207
Merged
kdroidFilter merged 1 commit intomasterfrom Apr 17, 2026
Merged
fix(mac): apply rotation metadata and reach 100% on progress bar#207kdroidFilter merged 1 commit intomasterfrom
kdroidFilter merged 1 commit intomasterfrom
Conversation
- Set AVVideoComposition built from the asset's preferred transform on the AVPlayerItem so AVPlayerItemVideoOutput delivers pixel buffers already rotated to display orientation. Fixes #202 (portrait phone videos rendering sideways on JVM/macOS). - Drop the 0.5s position-based fallback in checkLoopingAsync that was triggering pauseInBackground half a second before the actual end, freezing sliderPos at (duration - 0.5)/duration. Rely solely on AVPlayerItemDidPlayToEndTime, which is reliable on macOS. - gitignore the prebuilt darwin-aarch64/x86-64 dylib resource dirs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AVVideoComposition(built from the asset's preferred transform) on theAVPlayerItemsoAVPlayerItemVideoOutputdelivers pixel buffers already rotated to display orientation. Skipped for HLS streams whose tracks aren't synchronously available.checkLoopingAsynchad a 0.5 s position-based fallback that triggeredpauseInBackground()half a second before the real end, freezingsliderPosat(duration - 0.5) / duration— visibly short for short videos. Removed the fallback; we now trustAVPlayerItemDidPlayToEndTime, which fires reliably on macOS for both file and HLS playback.darwin-aarch64/anddarwin-x86-64/dylib resource directories so they don't accidentally get committed.Test plan
mediaplayer/src/jvmMain/native/macos/build.shfor botharm64andx86_64and confirm clean compilation.