-
Notifications
You must be signed in to change notification settings - Fork 637
refactor!: migrate to TypeScript #694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sheerlox
merged 30 commits into
kelektiv:beta
from
sheerlox:refactor/typescript-migration
Sep 26, 2023
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
bfd47da
chore: rename lib to src
sheerlox f549c71
chore: add TS, remove typings, add typings credits, update gitignore
sheerlox ecd0429
chore: rename cron.js to cron.ts
sheerlox c8442bd
refactor: migrate cron.ts to TypeScript
sheerlox 77a423f
ci: build project before running tests
sheerlox 6ae54d3
revert: "test: add TS types check"
sheerlox 7954ab0
build(npm): update package-lock.json
sheerlox cb009f4
ci: upgrade npm, use cache for tests & build before releasing
sheerlox c26a491
ci: drop testing on unsupported node version 14.x, add 20.x
sheerlox 758d0a6
chore: rename cron.ts to index.ts
sheerlox 4947ee1
chore: rename time.js to time.ts
sheerlox 5872ce2
refactor: migrate time.ts to TypeScript
sheerlox 93a3035
chore: rename job.js to job.ts
sheerlox 26095f6
chore: temporarily disable lint script
sheerlox 5ed5df4
refactor!: migrate job.ts to TypeScript
sheerlox ae84034
chore: enable strictest TypeScript mode
sheerlox 6f81e26
build(npm): don't ship source maps with bundle
sheerlox 61b98e0
refactor: improve time.ts typings
sheerlox f806e76
refactor!: improve typings
sheerlox ad6e690
chore: add vscode jest debug config
sheerlox 60fd6f8
style: reconfigure linters
sheerlox e5f8294
refactor: migrate tests to TypeScript
sheerlox 4ee22ed
chore: add coverage folder to .prettierignore
sheerlox 25ca080
style: configure linting for tests
sheerlox 3e56f80
feat!: remove superfluous time() factory function
sheerlox 625d8f8
build: fix npm build command
sheerlox 62d96ea
test: adjust coverage thresholds
sheerlox 795013d
fix: restore legacy behavior after merging #685
sheerlox f7bf656
docs(examples): update code examples
sheerlox 32245e4
docs(readme): update README
sheerlox File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,25 +1,60 @@ | ||
| { | ||
| "extends": [ | ||
| "standard", | ||
| "plugin:jest/recommended", | ||
| "plugin:import/recommended", | ||
| "plugin:n/recommended", | ||
| "plugin:prettier/recommended", | ||
| "plugin:promise/recommended" | ||
| ], | ||
| "parser": "@typescript-eslint/parser", | ||
| "parserOptions": { | ||
| "ecmaVersion": 2018 | ||
| }, | ||
| "globals": { | ||
| "define": "readonly" | ||
| "project": "tsconfig.json", | ||
| "sourceType": "module" | ||
| }, | ||
| "plugins": ["@typescript-eslint/eslint-plugin"], | ||
| "extends": [ | ||
| "plugin:@typescript-eslint/recommended", | ||
| "plugin:@typescript-eslint/recommended-requiring-type-checking", | ||
| "plugin:@typescript-eslint/strict", | ||
| "plugin:prettier/recommended" | ||
| ], | ||
| "root": true, | ||
| "env": { | ||
| "browser": true, | ||
| "es6": true, | ||
| "node": true, | ||
| "jest/globals": true | ||
| "node": true | ||
| }, | ||
| "rules": { | ||
| "jest/no-done-callback": "off" | ||
| } | ||
| "@typescript-eslint/no-unused-vars": [ | ||
| "warn", | ||
| { | ||
| "argsIgnorePattern": "^_" | ||
| } | ||
| ], | ||
| "@typescript-eslint/naming-convention": [ | ||
| "warn", | ||
| { | ||
| "selector": ["typeLike"], | ||
| "format": ["PascalCase"] | ||
| }, | ||
| { | ||
| "selector": ["variableLike", "function"], | ||
| "format": ["camelCase"], | ||
| "leadingUnderscore": "allow" | ||
| }, | ||
| { | ||
| "selector": ["variable"], | ||
| "format": ["camelCase", "UPPER_CASE"] | ||
| }, | ||
| { | ||
| "selector": "variable", | ||
| "types": ["boolean"], | ||
| "format": ["PascalCase"], | ||
| "prefix": ["is", "should", "has", "can", "did", "was", "will"] | ||
| } | ||
| ] | ||
| }, | ||
| "overrides": [ | ||
| { | ||
| "files": ["tests/**/*.ts"], | ||
| "plugins": ["jest"], | ||
| "extends": ["plugin:jest/recommended", "plugin:jest/style"], | ||
| "rules": { | ||
| "@typescript-eslint/no-empty-function": "off", | ||
| "@typescript-eslint/unbound-method": "off", | ||
| "jest/no-done-callback": "off" | ||
| } | ||
| } | ||
| ] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,130 @@ | ||
| *.sw[a-z] | ||
| node_modules | ||
| coverage | ||
| # Logs | ||
| logs | ||
| *.log | ||
| npm-debug.log* | ||
| yarn-debug.log* | ||
| yarn-error.log* | ||
| lerna-debug.log* | ||
| .pnpm-debug.log* | ||
|
|
||
| # Diagnostic reports (https://nodejs.org/api/report.html) | ||
| report.[0-9]*.[0-9]*.[0-9]*.[0-9]*.json | ||
|
|
||
| # Runtime data | ||
| pids | ||
| *.pid | ||
| *.seed | ||
| *.pid.lock | ||
|
|
||
| # Directory for instrumented libs generated by jscoverage/JSCover | ||
| lib-cov | ||
|
|
||
| # Coverage directory used by tools like istanbul | ||
| coverage | ||
| *.lcov | ||
|
|
||
| # nyc test coverage | ||
| .nyc_output | ||
|
|
||
| # Grunt intermediate storage (https://gruntjs.com/creating-plugins#storing-task-files) | ||
| .grunt | ||
|
|
||
| # Bower dependency directory (https://bower.io/) | ||
| bower_components | ||
|
|
||
| # node-waf configuration | ||
| .lock-wscript | ||
|
|
||
| # Compiled binary addons (https://nodejs.org/api/addons.html) | ||
| build/Release | ||
|
|
||
| # Dependency directories | ||
| node_modules/ | ||
| jspm_packages/ | ||
|
|
||
| # Snowpack dependency directory (https://snowpack.dev/) | ||
| web_modules/ | ||
|
|
||
| # TypeScript cache | ||
| *.tsbuildinfo | ||
|
|
||
| # Optional npm cache directory | ||
| .npm | ||
|
|
||
| # Optional eslint cache | ||
| .eslintcache | ||
|
|
||
| # Optional stylelint cache | ||
| .stylelintcache | ||
|
|
||
| # Microbundle cache | ||
| .rpt2_cache/ | ||
| .rts2_cache_cjs/ | ||
| .rts2_cache_es/ | ||
| .rts2_cache_umd/ | ||
|
|
||
| # Optional REPL history | ||
| .node_repl_history | ||
|
|
||
| # Output of 'npm pack' | ||
| *.tgz | ||
|
|
||
| # Yarn Integrity file | ||
| .yarn-integrity | ||
|
|
||
| # dotenv environment variable files | ||
| .env | ||
| .env.development.local | ||
| .env.test.local | ||
| .env.production.local | ||
| .env.local | ||
|
|
||
| # parcel-bundler cache (https://parceljs.org/) | ||
| .cache | ||
| .parcel-cache | ||
|
|
||
| # Next.js build output | ||
| .next | ||
| out | ||
|
|
||
| # Nuxt.js build / generate output | ||
| .nuxt | ||
| dist | ||
|
|
||
| # Gatsby files | ||
| .cache/ | ||
| # Comment in the public line in if your project uses Gatsby and not Next.js | ||
| # https://nextjs.org/blog/next-9-1#public-directory-support | ||
| # public | ||
|
|
||
| # vuepress build output | ||
| .vuepress/dist | ||
|
|
||
| # vuepress v2.x temp and cache directory | ||
| .temp | ||
| .cache | ||
|
|
||
| # Docusaurus cache and generated files | ||
| .docusaurus | ||
|
|
||
| # Serverless directories | ||
| .serverless/ | ||
|
|
||
| # FuseBox cache | ||
| .fusebox/ | ||
|
|
||
| # DynamoDB Local files | ||
| .dynamodb/ | ||
|
|
||
| # TernJS port file | ||
| .tern-port | ||
|
|
||
| # Stores VSCode versions used for testing VSCode extensions | ||
| .vscode-test | ||
|
|
||
| # yarn v2 | ||
| .yarn/cache | ||
| .yarn/unplugged | ||
| .yarn/build-state.yml | ||
| .yarn/install-state.gz | ||
| .pnp.* |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| CHANGELOG.md | ||
| dist/ | ||
| coverage/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "version": "1.0.0", | ||
| "configurations": [ | ||
| { | ||
| "type": "node", | ||
| "request": "launch", | ||
| "name": "Jest Debug", | ||
| "env": { "NODE_ENV": "test" }, | ||
| "program": "${workspaceFolder}/node_modules/.bin/jest", | ||
| "args": [], | ||
| "console": "integratedTerminal", | ||
| "windows": { | ||
| "program": "${workspaceFolder}/node_modules/jest/bin/jest" | ||
| } | ||
| } | ||
| ] | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.