Skip to content

refactor!: migrate to TypeScript#694

Merged
sheerlox merged 30 commits intokelektiv:betafrom
sheerlox:refactor/typescript-migration
Sep 26, 2023
Merged

refactor!: migrate to TypeScript#694
sheerlox merged 30 commits intokelektiv:betafrom
sheerlox:refactor/typescript-migration

Conversation

@sheerlox
Copy link
Copy Markdown
Collaborator

@sheerlox sheerlox commented Sep 10, 2023 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • If my change introduces a breaking change, I have added a ! after the type/scope in the title (see the Conventional Commits standard).

Breaking changes

  • removed cron.job() method in favor of new CronJob(...args) / CronJob.from(argsObject)
  • removed cron.time() method in favor of new CronTime()
  • CronJob: constructor no longer accepts an object as its first and only params. Use CronJob.from(argsObject) instead.
  • CronJob: callbacks are now called in the order they were registered

@sheerlox sheerlox self-assigned this Sep 10, 2023
@sheerlox sheerlox force-pushed the refactor/typescript-migration branch 4 times, most recently from e533351 to bb25602 Compare September 10, 2023 16:30
@sheerlox sheerlox force-pushed the refactor/typescript-migration branch from 12d0237 to 8d3423a Compare September 10, 2023 16:39
@sheerlox sheerlox mentioned this pull request Sep 10, 2023
Open
39 tasks
@sheerlox sheerlox force-pushed the refactor/typescript-migration branch 2 times, most recently from 4e1e777 to 9591b63 Compare September 10, 2023 17:00
@sheerlox
chore: rename cron.ts to index.ts
758d0a6
@sheerlox
chore: rename time.js to time.ts
4947ee1
@sheerlox
refactor: migrate time.ts to TypeScript
5872ce2
@sheerlox
chore: rename job.js to job.ts
93a3035
@sheerlox
chore: temporarily disable lint script
26095f6
@sheerlox
refactor!: migrate job.ts to TypeScript
5ed5df4 
BREAKING CHANGE: `CronJob`'s constructor no longer accepts an object as its first and only param. Use `CronJob.from(argsObject)` instead.
BREAKING CHANGE: removed `cron.job()` method in favor of `new CronJob()` / `CronJob.from()`
@sheerlox sheerlox force-pushed the refactor/typescript-migration branch from eb65983 to 6c6b856 Compare September 11, 2023 15:23
@sheerlox sheerlox force-pushed the refactor/typescript-migration branch from f82fa43 to a1dbc5c Compare September 24, 2023 09:10
@sheerlox
refactor!: improve typings
f806e76 
BREAKING CHANGE: callbacks are now called in the order they were registered
@sheerlox sheerlox force-pushed the refactor/typescript-migration branch from 8976e81 to 32245e4 Compare September 25, 2023 17:20
@sheerlox sheerlox marked this pull request as ready for review September 25, 2023 17:22
@sheerlox sheerlox requested a review from intcreator September 25, 2023 17:22
intcreator
intcreator reviewed Sep 26, 2023
View reviewed changes
@sheerlox sheerlox mentioned this pull request Aug 15, 2023
Draft
1 task
@sheerlox sheerlox requested a review from intcreator September 26, 2023 18:06
@sheerlox sheerlox merged commit 97a65e1 into kelektiv:beta Sep 26, 2023
@sheerlox sheerlox deleted the refactor/typescript-migration branch September 26, 2023 18:14
ncb000gt pushed a commit that referenced this pull request Sep 26, 2023
@semantic-release-bot
Release v3.0.0-beta.6 [skip ci]
e030f8b 
## [3.0.0-beta.6](v3.0.0-beta.5...v3.0.0-beta.6) (2023-09-26)

### ⚠ Breaking changes

* removed `cron.job()` method in favor of `new CronJob(...args)` /
`CronJob.from(argsObject)`
* removed `cron.time()` method in favor of `new CronTime()`
* `CronJob`: constructor no longer accepts an object as its first and
only params. Use `CronJob.from(argsObject)` instead.
* `CronJob`: callbacks are now called in the order they were registered

### 📦 Code Refactoring

* migrate to TypeScript ([#694](#694)) ([97a65e1](97a65e1))
@ncb000gt
Copy link
Copy Markdown
Member

ncb000gt commented Sep 26, 2023

🎉 This PR is included in version 3.0.0-beta.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

intcreator
intcreator approved these changes Sep 26, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@intcreator intcreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did a quick scan of everything and I think it looks ok. I'll take a more in depth look later

sheerlox added a commit that referenced this pull request Sep 27, 2023
@sheerlox
refactor!: migrate to TypeScript (#694)
af1d69e 
BREAKING CHANGE: removed `cron.job()` method in favor of `new CronJob(...args)` /
`CronJob.from(argsObject)`
BREAKING CHANGE: removed `cron.time()` method in favor of `new CronTime()`
BREAKING CHANGE: `CronJob`: constructor no longer accepts an object as its first and
only params. Use `CronJob.from(argsObject)` instead.
BREAKING CHANGE: `CronJob`: callbacks are now called in the order they were registered
sheerlox added a commit that referenced this pull request Sep 27, 2023
@sheerlox
refactor!: migrate to TypeScript (#694)
5fdfbee 
BREAKING CHANGE: removed `cron.job()` method in favor of `new CronJob(...args)` /
`CronJob.from(argsObject)`
BREAKING CHANGE: removed `cron.time()` method in favor of `new CronTime()`
BREAKING CHANGE: `CronJob`: constructor no longer accepts an object as its first and
only params. Use `CronJob.from(argsObject)` instead.
BREAKING CHANGE: `CronJob`: callbacks are now called in the order they were registered
sheerlox added a commit to sheerlox/node-cron that referenced this pull request Sep 27, 2023
@sheerlox
refactor!: migrate to TypeScript (kelektiv#694)
7e00a40 
BREAKING CHANGE: removed `cron.job()` method in favor of `new CronJob(...args)` /
`CronJob.from(argsObject)`
BREAKING CHANGE: removed `cron.time()` method in favor of `new CronTime()`
BREAKING CHANGE: `CronJob`: constructor no longer accepts an object as its first and
only params. Use `CronJob.from(argsObject)` instead.
BREAKING CHANGE: `CronJob`: callbacks are now called in the order they were registered
sheerlox added a commit to sheerlox/node-cron that referenced this pull request Sep 27, 2023
@sheerlox
refactor!: migrate to TypeScript (kelektiv#694)
fc27a0f 
BREAKING CHANGE: removed `cron.job()` method in favor of `new CronJob(...args)` /
`CronJob.from(argsObject)`
BREAKING CHANGE: removed `cron.time()` method in favor of `new CronTime()`
BREAKING CHANGE: `CronJob`: constructor no longer accepts an object as its first and
only params. Use `CronJob.from(argsObject)` instead.
BREAKING CHANGE: `CronJob`: callbacks are now called in the order they were registered
sheerlox added a commit to sheerlox/node-cron that referenced this pull request Sep 29, 2023
@sheerlox
refactor!: migrate to TypeScript (kelektiv#694)
e87ad09 
BREAKING CHANGE: removed `cron.job()` method in favor of `new CronJob(...args)` /
`CronJob.from(argsObject)`
BREAKING CHANGE: removed `cron.time()` method in favor of `new CronTime()`
BREAKING CHANGE: `CronJob`: constructor no longer accepts an object as its first and
only params. Use `CronJob.from(argsObject)` instead.
BREAKING CHANGE: `CronJob`: callbacks are now called in the order they were registered
sheerlox added a commit to sheerlox/node-cron that referenced this pull request Sep 29, 2023
@sheerlox
refactor!: migrate to TypeScript (kelektiv#694)
6f089a3 
BREAKING CHANGE: removed `cron.job()` method in favor of `new CronJob(...args)` /
`CronJob.from(argsObject)`
BREAKING CHANGE: removed `cron.time()` method in favor of `new CronTime()`
BREAKING CHANGE: `CronJob`: constructor no longer accepts an object as its first and
only params. Use `CronJob.from(argsObject)` instead.
BREAKING CHANGE: `CronJob`: callbacks are now called in the order they were registered
sheerlox added a commit to sheerlox/node-cron that referenced this pull request Sep 29, 2023
@sheerlox
refactor!: migrate to TypeScript (kelektiv#694)
f736d4c 
BREAKING CHANGE: removed `cron.job()` method in favor of `new CronJob(...args)` /
`CronJob.from(argsObject)`
BREAKING CHANGE: removed `cron.time()` method in favor of `new CronTime()`
BREAKING CHANGE: `CronJob`: constructor no longer accepts an object as its first and
only params. Use `CronJob.from(argsObject)` instead.
BREAKING CHANGE: `CronJob`: callbacks are now called in the order they were registered
sheerlox added a commit to sheerlox/node-cron that referenced this pull request Sep 29, 2023
@sheerlox
refactor!: migrate to TypeScript (kelektiv#694)
fbc1913 
BREAKING CHANGE: removed `cron.job()` method in favor of `new CronJob(...args)` /
`CronJob.from(argsObject)`
BREAKING CHANGE: removed `cron.time()` method in favor of `new CronTime()`
BREAKING CHANGE: `CronJob`: constructor no longer accepts an object as its first and
only params. Use `CronJob.from(argsObject)` instead.
BREAKING CHANGE: `CronJob`: callbacks are now called in the order they were registered
@sheerlox sheerlox mentioned this pull request Sep 29, 2023
Merged
sheerlox added a commit that referenced this pull request Sep 30, 2023
@sheerlox
refactor!: migrate to TypeScript (#694)
2d77894 
BREAKING CHANGE: removed `cron.job()` method in favor of `new CronJob(...args)` /
`CronJob.from(argsObject)`
BREAKING CHANGE: removed `cron.time()` method in favor of `new CronTime()`
BREAKING CHANGE: `CronJob`: constructor no longer accepts an object as its first and
only params. Use `CronJob.from(argsObject)` instead.
BREAKING CHANGE: `CronJob`: callbacks are now called in the order they were registered
ncb000gt pushed a commit that referenced this pull request Sep 30, 2023
@semantic-release-bot
Release v3.0.0 [skip ci]
a7dee32 
## [3.0.0](v2.4.4...v3.0.0) (2023-09-30)

### ⚠ Breaking changes

* `utcOffset` parameter no longer accepts a string
* `utcOffset` values between -60 and 60 are no longer
treated as hours
* providing both `timeZone` and `utcOffset` parameters
now throws an error
* removed `cron.job()` method in favor of `new CronJob(...args)` /
`CronJob.from(argsObject)`
* removed `cron.time()` method in favor of `new CronTime()`
* `CronJob`: constructor no longer accepts an object as its first and
only params. Use `CronJob.from(argsObject)` instead.
* `CronJob`: callbacks are now called in the order they were registered
* return empty array from nextDates when called without argument (#519)
* UNIX standard alignments (#667)

### ✨ Features

* expose useful types ([737b344](737b344))
* rework utcOffset parameter ([#699](#699)) ([671e933](671e933))
* UNIX standard alignments ([#667](#667)) ([ff615f1](ff615f1))

### 🐛 Bug Fixes

* return empty array from nextDates when called without argument ([#519](#519)) ([c2891ba](c2891ba))

### 📦 Code Refactoring

* migrate to TypeScript ([#694](#694)) ([2d77894](2d77894))

### 📚 Documentation

* **readme:** remove outdated informations ([#695](#695)) ([b5ceaf1](b5ceaf1))

### 🚨 Tests

* update new test for cron standard alignments ([4a406c1](4a406c1))

### ♻️ Chores

* improve GitHub community standards ([#698](#698)) ([6bdef77](6bdef77))
* update contributors list ([dab3d69](dab3d69))

### 💎 Styles

* fix linting issues ([47e665f](47e665f))
@sheerlox sheerlox added released type:refactor Changes that neither fixes a bug nor adds a feature and removed released on @beta labels Sep 30, 2023
@sheerlox sheerlox removed their assignment Oct 23, 2023
@coderabbitai coderabbitai bot mentioned this pull request Mar 26, 2026
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@intcreator intcreator intcreator approved these changes

Assignees

No one assigned

Labels

released type:refactor Changes that neither fixes a bug nor adds a feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sheerlox @ncb000gt @intcreator