chore: improve GitHub community standards#698
Merged
sheerlox merged 5 commits intokelektiv:mainfrom Sep 26, 2023
Merged
Conversation
intcreator
reviewed
Sep 26, 2023
intcreator
reviewed
Sep 26, 2023
intcreator
reviewed
Sep 26, 2023
intcreator
reviewed
Sep 26, 2023
intcreator
reviewed
Sep 26, 2023
intcreator
reviewed
Sep 26, 2023
intcreator
reviewed
Sep 26, 2023
intcreator
reviewed
Sep 26, 2023
intcreator
reviewed
Sep 26, 2023
intcreator
requested changes
Sep 26, 2023
Collaborator
intcreator
left a comment
intcreator
left a comment
There was a problem hiding this comment.
this looks great! I found a couple issues with links that should be addressed is all
Collaborator
Author
|
@intcreator I have addressed all of your comments! Thank you for reviewing that PR closely with your keen sight 😉 |
intcreator
approved these changes
Sep 26, 2023
Collaborator
|
approved! |
sheerlox
added a commit
to sheerlox/node-cron
that referenced
this pull request
Sep 27, 2023
ncb000gt
pushed a commit
that referenced
this pull request
Sep 29, 2023
## [3.0.0-beta.9](v3.0.0-beta.8...v3.0.0-beta.9) (2023-09-29) ### ⚠ Breaking changes * `utcOffset` parameter no longer accepts a string * `utcOffset` values between -60 and 60 are no longer treated as hours * providing both `timeZone` and `utcOffset` parameters now throws an error ### ✨ Features * rework utcOffset parameter ([#699](#699)) ([72d3d36](72d3d36)) ### ♻️ Chores * improve GitHub community standards ([#698](#698)) ([6bdef77](6bdef77)) ### 💎 Styles * fix linting issues ([b48c1b2](b48c1b2))
Member
|
🎉 This PR is included in version 3.0.0-beta.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
sheerlox
added a commit
to sheerlox/node-cron
that referenced
this pull request
Sep 29, 2023
sheerlox
added a commit
to sheerlox/node-cron
that referenced
this pull request
Sep 29, 2023
ncb000gt
pushed a commit
that referenced
this pull request
Sep 30, 2023
## [3.0.0](v2.4.4...v3.0.0) (2023-09-30) ### ⚠ Breaking changes * `utcOffset` parameter no longer accepts a string * `utcOffset` values between -60 and 60 are no longer treated as hours * providing both `timeZone` and `utcOffset` parameters now throws an error * removed `cron.job()` method in favor of `new CronJob(...args)` / `CronJob.from(argsObject)` * removed `cron.time()` method in favor of `new CronTime()` * `CronJob`: constructor no longer accepts an object as its first and only params. Use `CronJob.from(argsObject)` instead. * `CronJob`: callbacks are now called in the order they were registered * return empty array from nextDates when called without argument (#519) * UNIX standard alignments (#667) ### ✨ Features * expose useful types ([737b344](737b344)) * rework utcOffset parameter ([#699](#699)) ([671e933](671e933)) * UNIX standard alignments ([#667](#667)) ([ff615f1](ff615f1)) ### 🐛 Bug Fixes * return empty array from nextDates when called without argument ([#519](#519)) ([c2891ba](c2891ba)) ### 📦 Code Refactoring * migrate to TypeScript ([#694](#694)) ([2d77894](2d77894)) ### 📚 Documentation * **readme:** remove outdated informations ([#695](#695)) ([b5ceaf1](b5ceaf1)) ### 🚨 Tests * update new test for cron standard alignments ([4a406c1](4a406c1)) ### ♻️ Chores * improve GitHub community standards ([#698](#698)) ([6bdef77](6bdef77)) * update contributors list ([dab3d69](dab3d69)) ### 💎 Styles * fix linting issues ([47e665f](47e665f))
Member
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
sheerlox
added
type:chore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In order to guide potential new contributors, this PR improves GitHub community standards thanks to the following changes:
CODE_OF_CONDUCT.md,CONTRIBUTING.mdRelated Issue
Fixes #696.