feat: add validating webhook for KeptnTaskDefinition by geoffrey1330 · Pull Request #1514 · keptn/lifecycle-toolkit

geoffrey1330 · 2023-06-02T09:05:08Z

Fixes #1486 Added webhook validation for TaskDefinitions in the lifecycle operator

netlify · 2023-06-02T09:05:32Z

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

Name	Link
🔨 Latest commit	`d6a4800`
🔍 Latest deploy log	https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/6479b0c6f1636a000893ebb4
😎 Deploy Preview	https://deploy-preview-1514--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com> Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>

…r container spec but not both Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>

…ffrey1330/lifecycle-toolkit into feat/1486/validating_webhook Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>

…r container spec but not both Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>

rakshitgondwal

We need this webhook to work when a KeptnTaskDefinition gets created or updated, thus we'll need to return the validateKeptnTaskDefinition function on ValidateCreate and ValidateUpdate.

Co-authored-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com> Signed-off-by: Geoffrey Israel <israelgeoffrey13@gmail.com>

…r container spec but not both Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>

rakshitgondwal

Made a small typo, sorry. Can you fix this? @geoffrey1330

Co-authored-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com> Signed-off-by: Geoffrey Israel <israelgeoffrey13@gmail.com>

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>

…est.go Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com> Signed-off-by: Geoffrey Israel <israelgeoffrey13@gmail.com>

…) methods Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>

sonarqubecloud · 2023-06-06T08:11:18Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

odubajDT · 2023-06-07T07:51:57Z

@rakshitgondwal @geoffrey1330 awesome job! Thank you very much for contribution :)

rakshitgondwal · 2023-06-07T08:11:41Z

Kudos to @geoffrey1330!

geoffrey1330 · 2023-06-07T08:17:18Z

Kudos to @geoffrey1330!

Thanks for the support @rakshitgondwal

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com> Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com> Signed-off-by: Geoffrey Israel <israelgeoffrey13@gmail.com> Co-authored-by: odubajDT <93584209+odubajDT@users.noreply.github.com> Co-authored-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com> Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com>

geoffrey1330 requested a review from a team as a code owner June 2, 2023 09:05

github-actions Bot added the operator label Jun 2, 2023

odubajDT and others added 2 commits June 2, 2023 14:20

feat: integrate python-runtime into pipelines (keptn#1505)

e66f2a5

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com> Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>

added validating webhook for TaskDefinitions

2af1475

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>

geoffrey1330 force-pushed the feat/1486/validating_webhook branch from d6a4800 to 2af1475 Compare June 2, 2023 13:20

github-actions Bot added documentation Improvements or additions to documentation helm ops labels Jun 2, 2023

geoffrey1330 added 3 commits June 2, 2023 15:23

added validating webhook for TaskDefinitions

1f6d09c

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>

Added TaskDefinition validation logic to allow either Function spec o…

cee0114

…r container spec but not both Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>

Merge branch 'main' into feat/1486/validating_webhook

184673d

github-actions Bot removed documentation Improvements or additions to documentation ops helm labels Jun 2, 2023

geoffrey1330 added 2 commits June 2, 2023 16:22

Merge branch 'feat/1486/validating_webhook' of https://github.com/geo…

7dd8a8c

…ffrey1330/lifecycle-toolkit into feat/1486/validating_webhook Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>

Added TaskDefinition validation logic to allow either Function spec o…

42c8193

…r container spec but not both Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>

rakshitgondwal requested changes Jun 2, 2023

View reviewed changes

geoffrey1330 and others added 10 commits June 2, 2023 18:16

Update operator/apis/lifecycle/v1alpha3/keptntaskdefinition_webhook.go

caca04d

Co-authored-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com> Signed-off-by: Geoffrey Israel <israelgeoffrey13@gmail.com>

Update operator/apis/lifecycle/v1alpha3/keptntaskdefinition_webhook.go

adf509c

Co-authored-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com> Signed-off-by: Geoffrey Israel <israelgeoffrey13@gmail.com>

Update operator/apis/lifecycle/v1alpha3/keptntaskdefinition_webhook.go

658e71e

Co-authored-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com> Signed-off-by: Geoffrey Israel <israelgeoffrey13@gmail.com>

Update operator/apis/lifecycle/v1alpha3/keptntaskdefinition_webhook.go

2f46086

Co-authored-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com> Signed-off-by: Geoffrey Israel <israelgeoffrey13@gmail.com>

Update operator/apis/lifecycle/v1alpha3/keptntaskdefinition_webhook.go

3c45ddb

Co-authored-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com> Signed-off-by: Geoffrey Israel <israelgeoffrey13@gmail.com>

Added TaskDefinition validation logic to allow either Function spec o…

101f20a

…r container spec but not both Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>

added ValidatingWebhookConfiguration manifest

1fd9ff4

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>

added ValidatingWebhookConfiguration manifest

95c8234

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>

deleted webhook_suite_test.go file

609d75a

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>

Added neccessary import for keptntaskdefinition_webhook

dcb52c7

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>

rakshitgondwal requested changes Jun 4, 2023

View reviewed changes

Comment thread operator/apis/lifecycle/v1alpha3/keptntaskdefinition_webhook.go Outdated

Comment thread operator/apis/lifecycle/v1alpha3/keptntaskdefinition_webhook.go Outdated

Comment thread operator/apis/lifecycle/v1alpha3/keptntaskdefinition_webhook.go Outdated

Update operator/apis/lifecycle/v1alpha3/keptntaskdefinition_webhook.go

74f7d39

Co-authored-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com> Signed-off-by: Geoffrey Israel <israelgeoffrey13@gmail.com>

geoffrey1330 added 4 commits June 5, 2023 10:45

Added comment to the integration test for validating taskdefinition

16cc385

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>

Added comment to the integration test for validating taskdefinition

c2d4129

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>

Added comment to the integration test for validating taskdefinition

ba845ec

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>

Added comment to the integration test for validating taskdefinition

4528ea8

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>

bacherfl reviewed Jun 5, 2023

View reviewed changes

Comment thread operator/apis/lifecycle/v1alpha3/keptntaskdefinition_webhook_test.go

geoffrey1330 added 6 commits June 5, 2023 12:40

Added tests to cover the Validate[Create/Update/Delete]() methods

682151d

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>

Added tests to cover the Validate[Create/Update/Delete]() methods

eb83821

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>

Added tests to cover the Validate[Create/Update/Delete]() methods

f3cf46a

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>

Added tests to cover the Validate[Create/Update/Delete]() methods

7480936

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>

Added tests to cover the Validate[Create/Update/Delete]() methods

2cc657a

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>

Added tests to cover the Validate[Create/Update/Delete]() methods

1605588

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>

RealAnna reviewed Jun 5, 2023

View reviewed changes

Comment thread operator/apis/lifecycle/v1alpha3/keptntaskdefinition_webhook.go Outdated

Added tests to cover the Validate[Create/Update/Delete]() methods

8de7acf

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>

RealAnna reviewed Jun 5, 2023

View reviewed changes

Comment thread operator/apis/lifecycle/v1alpha3/keptntaskdefinition_webhook_test.go Outdated

Added tests to cover the Validate[Create/Update/Delete]() methods

9b464d8

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>

bacherfl reviewed Jun 6, 2023

View reviewed changes

Comment thread operator/apis/lifecycle/v1alpha3/keptntaskdefinition_webhook_test.go

geoffrey1330 and others added 2 commits June 6, 2023 08:58

Update operator/apis/lifecycle/v1alpha3/keptntaskdefinition_webhook_t…

330e3c4

…est.go Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com> Signed-off-by: Geoffrey Israel <israelgeoffrey13@gmail.com>

Added fixes for tests that covers the Validate[Create/Update/Delete](…

0d9daea

…) methods Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>

bacherfl approved these changes Jun 6, 2023

View reviewed changes

odubajDT approved these changes Jun 7, 2023

View reviewed changes

odubajDT merged commit d55a7ef into keptn:main Jun 7, 2023

keptn-bot mentioned this pull request Jun 7, 2023

chore: release 0.8.0 #1358

Merged

odubajDT mentioned this pull request Jun 7, 2023

chore: adapt validation webhook to consider new fields for python-runtime functionality #1527

Closed

3 tasks

geoffrey1330 mentioned this pull request Jun 22, 2023

REQUEST: Membership member for @geoffrey1330 keptn/community#293

Closed

7 tasks

keptn-bot mentioned this pull request Jun 26, 2023

chore: release klt 0.8.1 #1620

Merged

Conversation

geoffrey1330 commented Jun 2, 2023 • edited by thisthat Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify Bot commented Jun 2, 2023

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

Uh oh!

rakshitgondwal left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rakshitgondwal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud Bot commented Jun 6, 2023

Uh oh!

odubajDT commented Jun 7, 2023

Uh oh!

rakshitgondwal commented Jun 7, 2023

Uh oh!

geoffrey1330 commented Jun 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

geoffrey1330 commented Jun 2, 2023 •

edited by thisthat

Loading

rakshitgondwal left a comment •

edited

Loading