-
Notifications
You must be signed in to change notification settings - Fork 155
docs(ui): update Welcome page screenshot and button text #3547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(ui): update Welcome page screenshot and button text #3547
Conversation
|
Hey @MilosPaunovic ,I have opened another PR as requested and have completed most of the work. |
|
Where are the GH closing keywords? Just a small note for the future, if you could use GitHub Keywords when opening PRs to connect it to the proper issue (to automate the entire process a bit more), it would be super helpful to us. You can read a bit more about it here (I've added closing keyword for this particular issue). |
MilosPaunovic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The text change is alright, but we don't want the image used as a working wireframe from the kestra-io/kestra#13803 to be used as a screenshot, we want the proper screenshot from the product.
|
Thanks for the clarification @MilosPaunovic ! |
|
I've added closing keywords into description of the pull request now, but next time, if there is a pull requests without one, it will be closed. |
|
Hello sir @MilosPaunovic , |
|
Closing keywords should be added to PR description, not to the comment. |
|
Your image looks kind of blurry. We'll take it from here, @aj-emerich will make the proper screenshot and update the PR once he's back from holiday. Thanks for your work so far @swagatika60, it's much appreciated! 🍀 |
|
Thanks a lot for the clarification🙏. |
96e08a9 to
12b69fd
Compare
|
@MilosPaunovic LGTM with the screenshot, anything else to consider? |
|
Nope, if you're okay with it, you can proceed with the merge as far as I'm concerned. |
|
@MilosPaunovic Just need your Approval click then 👍 |
Closes #3536.
This update brings the UI documentation in line with the recent Welcome page changes introduced in kestra-io/kestra#13803.
I’ve updated the Welcome page screenshot and adjusted the button text in the documentation so it matches the new button name shown in the UI.