docker/fedora/keylime_rust.Dockerfile: add the logic of cloning and compiling rust-keylime #584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansasaki
reviewed
May 11, 2023
Contributor
Author
|
Thanks @ansasaki . After adding the |
ansasaki
requested changes
May 19, 2023
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
…ompiling rust-keylime Obviously, the codes of the agent are located in the rust-keylime repository. However, there is no logic for cloning and compiling rust-keylime in the corresponding rust dockerfile. So we need to add it. Signed-off-by: YiLin.Li <YiLin.Li@linux.alibaba.com>
Contributor
Author
|
Thanks @ansasaki . I fixed it and force-pushed the codes. Could you review it again? |
ansasaki
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Obviously, the codes of the agent are located in the rust-keylime repository. However, there is no logic for cloning and compiling rust-keylime in the corresponding rust dockerfile. So we need to add it.
Fixes: #585
Signed-off-by: YiLin.Li YiLin.Li@linux.alibaba.com