Replace useless NilAccessDefect with useful LibraryError#1
Open
theAkito wants to merge 2 commits intokhchen:masterfrom
Open
Replace useless NilAccessDefect with useful LibraryError#1theAkito wants to merge 2 commits intokhchen:masterfrom
theAkito wants to merge 2 commits intokhchen:masterfrom
Conversation
Raising the `LibraryError` in line 313 shows exactly what library failed to load. If the `handle` variable assignment excepts, due to a `NilAccessDefect`, then you first have to debug the flow of your program to find the issue. Therefore, we catch the exception and raise a meaningful error, that is telling you exactly why the `LoadLibraryA` proc failed to execute.
Owner
|
Thank you for this PR! My questions:
|
Author
If you think this method for making more useful exceptions is helpful, perhaps it would be even better if all places where a NilAccessDefect could possibly be found would be improved by a more meaningful exception, in the same way as done in this commit (try catch all the possible failures)? To put all this in context: I was playing around with the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, thank you for yet another great library!
I wanted to contribute at least a bit, by fixing an issue I found when testing this library. 😃