Skip to content

Replace useless NilAccessDefect with useful LibraryError #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
theAkito wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Replace useless NilAccessDefect with useful LibraryError #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18ef040
Replace useless NilAccessDefect with useful LibraryError
theAkito May 31, 2021
71fac1c
1.0.1 Bump Version
theAkito May 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion memlib.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ proc buildImportTable(lib: MemoryModule) {.raises: [LibraryError].} =
for desc in codeBase.descriptors(directory):
let
cname = codeBase{desc.Name}[LPCSTR]
handle = LoadLibraryA(cname)
handle = try: LoadLibraryA(cname) except: 0

if handle == 0:
raise newException(LibraryError, $cname & " not found")
Expand Down
2 changes: 1 addition & 1 deletion memlib.nimble
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Package

version = "1.0.0"
version = "1.0.1"
author = "Ward"
description = "Memlib - Load Windows DLL from memory"
license = "MIT"
Expand Down