Merged
Conversation
epage
reviewed
Jun 20, 2022
Collaborator
epage
left a comment
epage
left a comment
There was a problem hiding this comment.
Thanks for getting this going!
Now with inserting and erroring (non-inserting) variants
Tests now point to a template `rm-target.in` instead of `rm_target.in`, which belongs to a test.
epage
reviewed
Jun 20, 2022
Opting for the original usage of `conflicts_with` for now. In the future, this group should only include `--build` and `--dev`.
Collaborator
|
Thanks! #682 is updated |
cassaundra
added a commit
to cassaundra/cargo-edit
that referenced
this pull request
Jun 28, 2022
This included splitting `Manifest::get_table_mut` into two functions with inserting and erroring (non-inserting) variants to allow for nested lookup for `rm`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
--targetflag to the cargo-rm command in the style of cargo-add's equivalent, with the only difference in usage being that this flag can be used in conjunction with--devor--build.In order to correctly handle certain cases with nested tables,
Manifest::get_table_mutis split into another functionManifest::get_or_insert_table_mut, with this change being propagated to all other internal usages (e.g. in cargo-add).