Change addon exported files from .coffee to .js#136
Conversation
|
Same here, will fix to make tests pass. |
|
@kimroen, pushed updated code with amended tests. Travis builds green now. |
|
@kimroen, What do you think of this? Is it merge-worthy? |
kimroen
left a comment
kimroen
left a comment
There was a problem hiding this comment.
Great, although in addition to the comment about the expectCoffee lines, I have a thing I would like someone to investigate. It could be a separate issue, though.
These files are now more or less identical to what the default ember -addon blueprints do. Can we remove them from ember-cli-coffeescript and still have them work?
I don't think we have tests for that, so we need to add a test for the addon-version of all the components that have addon-variants. Is that something you have the time to look into?
| .to.contain("export { default } from 'my-app/addon-imports/foo'"); | ||
| .to.contain("export { default } from 'my-app/addon-imports/foo';"); | ||
|
|
||
| expectCoffee(importFile); |
There was a problem hiding this comment.
These lines expect that the contents of the file in question is valid CoffeeScript, and that is not relevant for these tests that only involve JavaScript, so it should be removed.
|
Great, thank you again! |
|
Could we get a v1.16.1 with this fix included @kimroen? Pretty please with sugar on top. 😇 |
You absolutely could, but I'm in the middle of moving so I'm short on time. Hopefully soon! |
|
There we go! |
3 participants
This PR changes the
*-addonblueprints to use javascript files instead of coffeescript files. Without this change, addons usingember-cli-coffeecriptcreates files that can't be consumed in a application not usingember-cli-coffeescript.Fixes #131