Set POD_NAME env var for logger injection#30
Conversation
knative-prow-robot
added
the
approved
knative-prow-robot
added
the
size/XS
|
/assign aliok |
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
=======================================
Coverage 84.72% 84.72%
=======================================
Files 10 10
Lines 203 203
=======================================
Hits 172 172
Misses 23 23
Partials 8 8 Continue to review full report at Codecov.
|
| value: knative.dev/sources | ||
| - name: GL_RA_IMAGE | ||
| value: ko://knative.dev/eventing-gitlab/cmd/receive_adapter | ||
| - name: POD_NAMESPACE |
There was a problem hiding this comment.
Sorry, I am a bit out of context here.
I know we now inject POD_NAME to controllers, but don't we need POD_NAMESPACE anymore?
There was a problem hiding this comment.
I don't know about any controller using POD_NAMESPACE in Knative, and this one is no exception. Not sure where that came from.
There was a problem hiding this comment.
LOL, thanks for the explanation.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aliok, antoineco The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
Fixes #5
Proposed Changes
Release Note
Docs