Skip to content

Set POD_NAME env var for logger injection #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knative-prow-robot merged 1 commit into from
Nov 9, 2020
Merged

Set POD_NAME env var for logger injection #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions config/500-controller.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,10 @@ spec:
value: knative.dev/sources
- name: GL_RA_IMAGE
value: ko://knative.dev/eventing-gitlab/cmd/receive_adapter
- name: POD_NAMESPACE
Copy link
Copy Markdown
Member

@aliok aliok Nov 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I am a bit out of context here.

I know we now inject POD_NAME to controllers, but don't we need POD_NAMESPACE anymore?

Copy link
Copy Markdown
Contributor Author

@antoineco antoineco Nov 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know about any controller using POD_NAMESPACE in Knative, and this one is no exception. Not sure where that came from.

Copy link
Copy Markdown
Member

@aliok aliok Nov 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL, thanks for the explanation.

/lgtm
/approve

- name: POD_NAME
valueFrom:
fieldRef:
fieldPath: metadata.namespace
fieldPath: metadata.name
image: ko://knative.dev/eventing-gitlab/cmd/controller
resources:
limits:
Expand Down
4 changes: 4 additions & 0 deletions config/500-webhook.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,10 @@ spec:
value: knative.dev/eventing
- name: WEBHOOK_NAME
value: gitlab-webhook
- name: POD_NAME
valueFrom:
fieldRef:
fieldPath: metadata.name
ports:
- containerPort: 9090
name: metrics
Expand Down