Skip to content

feat: Add channel sink prefix#1092

Merged
knative-prow-robot merged 4 commits intoknative:masterfrom
navidshaikh:pr/channel-sink-prefix
Nov 9, 2020
Merged

feat: Add channel sink prefix#1092
knative-prow-robot merged 4 commits intoknative:masterfrom
navidshaikh:pr/channel-sink-prefix

Conversation

@navidshaikh
Copy link
Copy Markdown
Contributor

@navidshaikh navidshaikh commented Nov 5, 2020

Description

Add channel sink prefix, so user can now specify --sink channel:pipe0

Changes

  • Add channel sink prefix
  • Add unit and e2e tests
  • Add CHANGELOG

Reference

Fixes #1076

/lint

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 5, 2020
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2020
knative-prow-robot
knative-prow-robot reviewed Nov 5, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@navidshaikh: 0 warnings.

Details

In response to this:

Description

Add channel sink prefix, so user can now specify --sink channel:pipe0

Changes

  • Add channel sink prefix
  • Add unit and e2e tests
  • Add CHANGELOG

Reference

Fixes #1076

/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 5, 2020
@dsimansk
Copy link
Copy Markdown
Contributor

dsimansk commented Nov 5, 2020

/retest

rhuss
rhuss reviewed Nov 9, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me !

/lgtm
/approve

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Nov 9, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: navidshaikh, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 9, 2020
@knative-prow-robot knative-prow-robot merged commit 26867f1 into knative:master Nov 9, 2020
navidshaikh added a commit to navidshaikh/client that referenced this pull request Nov 10, 2020
@navidshaikh
feat: Add channel sink prefix (knative#1092)
bd30581 
* Add channel sink prefix

* Add unit and e2e tests

* Add CHANGELOG

* Fix e2e tests
@navidshaikh navidshaikh added the backport/candidate Consider this PR to be backported to the release branch label Nov 10, 2020
@navidshaikh navidshaikh mentioned this pull request Nov 10, 2020
Merged
navidshaikh added a commit to navidshaikh/client that referenced this pull request Nov 10, 2020
@navidshaikh
feat: Add channel sink prefix (knative#1092)
4ade890 
* Add channel sink prefix

* Add unit and e2e tests

* Add CHANGELOG

* Fix e2e tests
@navidshaikh navidshaikh mentioned this pull request Nov 10, 2020
Merged
knative-prow-robot pushed a commit that referenced this pull request Nov 10, 2020
@navidshaikh
[release-0.18] Backport #1092 (#1104)
47f59f0 
* feat: Add channel sink prefix (#1092)

* Add channel sink prefix

* Add unit and e2e tests

* Add CHANGELOG

* Fix e2e tests

* Add CHANGELOG for v0.18.2
@navidshaikh navidshaikh added backported-to/0.17 and removed backport/candidate Consider this PR to be backported to the release branch labels Nov 10, 2020
knative-prow-robot pushed a commit that referenced this pull request Nov 11, 2020
@navidshaikh
[release-0.17] Backport #1092 (#1105)
c17a432 
* feat: Add channel sink prefix (#1092)

* Add channel sink prefix

* Add unit and e2e tests

* Add CHANGELOG

* Fix e2e tests

* Add CHANGELOG for v0.17.3

* Add Channel type to dynamic client for lookup

 Fixes unit tests by adding Channel GVK to fake dynamic client

* Set KNATIVE_EVENTING_VERSION to v0.17.9 for e2e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@sixolet sixolet Awaiting requested review from sixolet

+1 more reviewer

@rhuss rhuss rhuss left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@rhuss rhuss

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add sink prefix "channel:" for allowing to address a channel

4 participants

@navidshaikh @dsimansk @knative-prow-robot @rhuss